Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should be #[inline]d? #4

Open
bheisler opened this issue Nov 25, 2018 · 3 comments
Open

What should be #[inline]d? #4

bheisler opened this issue Nov 25, 2018 · 3 comments
Labels
Help Wanted Input requested Intermediate Intermediate difficulty. May require knowledge of CUDA (or reading the Driver API docs)

Comments

@bheisler
Copy link
Owner

I'm not sure if RustaCUDA functions should be inlined or not, and if so, which ones?
@bheisler bheisler added Code Intermediate Intermediate difficulty. May require knowledge of CUDA (or reading the Driver API docs) Help Wanted Input requested and removed Code labels Nov 25, 2018
@rusch95
Copy link
Contributor

rusch95 commented Dec 3, 2018

Any functions you could see being a hotspot in a loop? (Especially, parts of the public API, since rust does inline across crates without #[inline] right now)

@bheisler
Copy link
Owner Author

bheisler commented Dec 4, 2018

Oh, is LTO on by default now? I didn't know that.

@rusch95
Copy link
Contributor

rusch95 commented Dec 4, 2018

Oof, I meant doesn't. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Input requested Intermediate Intermediate difficulty. May require knowledge of CUDA (or reading the Driver API docs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bheisler @rusch95