Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime parse error #40

Open
rogerfar opened this issue Jul 10, 2014 · 2 comments
Open

DateTime parse error #40

rogerfar opened this issue Jul 10, 2014 · 2 comments
Labels

Comments

@rogerfar
Copy link

When I parse my OData string with this datetime: datetime'2014-07-10T00:00:00.000'

I get an error: String was not recognized as a valid DateTime

I noticed this code in DateTimeNode.cs

        var dateText = this.Text
            .Replace("datetime'", string.Empty)
            .Replace("'", string.Empty)
            .Replace(".", ":");

The last replace makes the datetime string: 2014-07-10T00:00:00:000 but it should be 2014-07-10T00:00:00.000

When I read the OData specifications:

datetime’yyyy-mm-ddThh:mm[:ss[.fffffff]]’ NOTE: Spaces are not allowed between datetime and quoted portion. datetime is case-insensitive

I don't think there is a need to replace the . with a :, right?

@beyond-code-github
Copy link
Owner

I think you may be right there, good spot. I'll try to get this addressed in the next week or so.

@rogerfar
Copy link
Author

@roysvork did you manage to merge this fix in, or would you like a PR?

TheSharpieOne added a commit to TheSharpieOne/LinqToQuerystring that referenced this issue Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants