Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version support #1

Open
balupton opened this issue Jun 25, 2013 · 8 comments
Open

Add version support #1

balupton opened this issue Jun 25, 2013 · 8 comments
Labels
enhancement Improvement or suggestion

Comments

@balupton
Copy link
Member

No description provided.

@RobLoach
Copy link
Contributor

Used lazy-require for a thing:
https://github.com/jstransformers/jstransformer-cli

Well done on this, Ben! 👍

@Glavin001
Copy link

+1 version support would be great!

@balupton I just read over your code. If you could write up how you would like the API to be, I could implement this and submit a Pull Request for you to review 😃 . I was thinking that there be a version option or something similar.

@balupton
Copy link
Member Author

balupton commented Sep 5, 2015

@Glavin001 cool give me a moment, I'll move it from coffeescript to es6, then you can add your thing

have version as a properties of opts would be the way to go

@Glavin001
Copy link

Also I noticed one of the tests failed, "incomplete". Is that just me?

@balupton
Copy link
Member Author

balupton commented Sep 5, 2015

@Glavin001 es6 version released, so good for your pull request, tests passing for me

We're also on slack at https://slack.bevry.me

@ryanramage
Copy link

I like the idea to have version support.

One potential issue to navigate would be if a package was requested with two different versions, how the node_modules folder would look.

@Glavin001
Copy link

One potential issue to navigate would be if a package was requested with two different versions, how the node_modules folder would look.

It would only allow one. I suppose if the version of the most recent request was incompatible with the previously installed version then npm would trigger a fresh install of the currently requested version.

This is all backed by calling npm install <package> ( see https://github.com/bevry/lazy-require/blob/master/es6/lib/lazy-require.js#L238 ) so you could test the expected behaviour by running the commands in your Terminal.

@zhaoyao91
Copy link

is there any update on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or suggestion
Projects
None yet
Development

No branches or pull requests

5 participants