Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for event_type_ids to market_filter for simulation #777

Open
cpudney opened this issue Dec 13, 2024 · 4 comments
Open

Add support for event_type_ids to market_filter for simulation #777

cpudney opened this issue Dec 13, 2024 · 4 comments

Comments

@cpudney
Copy link

cpudney commented Dec 13, 2024

It would be useful if market_filter supported an event_type_id so that the data files were filtered by event type, e.g. to filter by soccer you would use:

market_filter={"markets": data_files, 'market_types': ['MATCH_ODDS'], "event_type_id": [1], "listener_kwargs": {'inplay': False}},
Thank you.

@arch4672
Copy link
Contributor

It already does support it, but it's event_type_ids (note the s on the end) and the ids in the list need to be strings not numbers, i.e. event_type_ids=["1"]

@liampauling
Copy link
Member

*simulation

Fairly sure it doesn't but its been a long week

if self.flumine.SIMULATED:

@arch4672
Copy link
Contributor

Ah, my bad didn't spot it was for simulation. You're right that's not supported.

@cpudney
Copy link
Author

cpudney commented Dec 14, 2024

Yes, this is for simulation - apologies for the lack of context. Ref. https://discord.com/channels/970549994090295296/976702821032423444/1316748170058924052

@cpudney cpudney changed the title Add support for event_type_id to market_filter Add support for event_type_ids to market_filter for simulation Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants