Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market On Close -> EXECUTION_COMPLETE #327

Open
liampauling opened this issue Nov 16, 2020 · 0 comments
Open

Market On Close -> EXECUTION_COMPLETE #327

liampauling opened this issue Nov 16, 2020 · 0 comments
Labels
bug

Comments

@liampauling
Copy link
Member

Market on close / limit on close orders go EXECUTION_COMPLETE on place

Backtesting?

Live>
liampauling added a commit that referenced this issue Dec 5, 2020
@liampauling
#327 correctly return orderStatus
bcef22c 
market/limit on close now execution complete on success
limit status now correct on place
liampauling added a commit that referenced this issue Dec 28, 2020
@liampauling
Merge pull request #346 from liampauling/task/327-correct-simulated-o…
365aab0 
…rder-status

#327 correctly return orderStatus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liampauling