Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When erasing part of a circle, the whole circle is erased #8

Open
bertyhell opened this issue Sep 28, 2024 · 2 comments
Open

When erasing part of a circle, the whole circle is erased #8

bertyhell opened this issue Sep 28, 2024 · 2 comments
Assignees
@P-yiush07

Comments

@bertyhell
Copy link
Owner

  • Draw a circle
  • Draw a rectangle that partly overlaps
  • Switch to the erase tool
  • Click the circle
    image

current behavior: The whole circle is deleted
image

expected behavior: Only a segment of the circle should be deleted until the nearest 2 intersection points
image
@P-yiush07
Copy link
Contributor

@bertyhell Assign me, i will solve this

P-yiush07 added a commit to P-yiush07/openwebcad that referenced this issue Sep 29, 2024
@P-yiush07
Fixed the issue bertyhell#8
c026b3b
@P-yiush07
Copy link
Contributor

Check the PR, I fixed this issue. #9

bertyhell added a commit that referenced this issue Sep 30, 2024
@bertyhell
Merge pull request #9 from P-yiush07/fixed-issue-08
399e406 
#8 Fixed the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P-yiush07 P-yiush07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertyhell @P-yiush07