Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Inject custom manifest configuration #1187

Open
3 tasks
bernardhalas opened this issue Jan 19, 2024 · 2 comments
Open
3 tasks

Feature: Inject custom manifest configuration #1187

bernardhalas opened this issue Jan 19, 2024 · 2 comments
Labels
feature New feature groomed Task that everybody agrees to pass the gatekeeper

Comments

@bernardhalas
Copy link
Member

bernardhalas commented Jan 19, 2024

Motivation

Claudie deploys some manifests, predominantly the Longorn, with sane defaults. However, there's currently no way how to customize them. This approach falls short (e.g. when using taints) or when the user would like to change the configuration of Longhorn or other Claudie-deployed components.

Description

Propose a way how to customize manifests that are being applied by Claudie's kuber service on the Claudie-made clusters.

Exit criteria

  • Propose an architecture that allows over-riding the default configs
  • Ensure that this approach is extendable to LBs in the future (the implementation will be done with another task though)
  • Implement the proposal
@Danielss89
Copy link
Contributor

One thing to keep in mind here is:
How is updates handled if the user has customized config files, and Claudie has added new config values or changed some. Is documentation on new/changed config values enough? Or can there be some smart way of "merging"?

@bernardhalas
Copy link
Member Author

Hi @Danielss89 , thank you for raising this. In fact we're about to design a solution so that these customizations are respected no matter to what happens to the clusters (upgrades, changes, etc.). There are several design options, and we need to choose the one that will fit us the best long-term. We'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Development

No branches or pull requests

2 participants