Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug] introduce a proper struct logging debug infos #4

Open
benjaminch opened this issue Jul 10, 2019 · 1 comment
Open

[debug] introduce a proper struct logging debug infos #4

benjaminch opened this issue Jul 10, 2019 · 1 comment
Assignees
@benjaminch
Labels
codebase-health

Comments

@benjaminch
Copy link
Owner

Avoid having all debug code within the pricer directly but defer it to a proper debug struct
@benjaminch benjaminch self-assigned this Jul 10, 2019
@stokito
Copy link
Contributor

stokito commented Sep 4, 2022

#12

stokito added a commit to stokito/pricers that referenced this issue Feb 26, 2023
@stokito
benjaminch#4 Remove debug logging
f8047a1 
The logging is almost useless for users but a developer can debug in IDE.
The raw keys bytes are not saying anything.
We have errors to return a message to a caller.
In the same time the code needs to be compiled and it makes the program slower because it resides in CPU cache.
stokito added a commit to stokito/pricers that referenced this issue Feb 26, 2023
@stokito
benjaminch#4 Remove debug logging
97a9d6b 
Remove deprecated isDebugMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminch benjaminch

Labels
codebase-health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stokito @benjaminch