Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solaris Support to Benchee.System #421

Closed
brianewell opened this issue Dec 22, 2023 · 3 comments
Closed

Add Solaris Support to Benchee.System #421

brianewell opened this issue Dec 22, 2023 · 3 comments

Comments

@brianewell
Copy link
Contributor

It would be nice for Benchee to recognize when it's running on Solaris/Illumos platforms instead of just assuming that it's on Linux, ie:

cat: /proc/meminfo: No such file or directory
Something went wrong trying to get system information:

cat: /proc/cpuinfo: No such file or directory
Something went wrong trying to get system information:

Operating System: Linux
CPU Information: N/A
Number of Available Cores: 48
Available memory: N/A
Elixir 1.15.7
Erlang 26.1.2

Would become:

Operating System: Solaris
CPU Information: Intel(r) Xeon(r) CPU E5-2678 v3 @ 2.50GHz
Number of Available Cores: 48
Available memory: 8 GB
Elixir 1.15.7
Erlang 26.1.2
JIT enabled: true
@PragTob
Copy link
Member

PragTob commented Dec 22, 2023

👋

Hi there, thanks for the report! Help is welcome with this - I don't have a solaris system or idea where to get that information in a Solaris information or how to recognize it's Solaris and not Linux.

If anyone could provide that information or even implement the feature I'd be very happy 😁

Otherwise, this will probably wait for a while for me to groom the backlog at some point and be like "ok let's get a VM and dive into this" 😁

@brianewell
Copy link
Contributor Author

This is my first PR for a public elixir library, please let me know if I missed anything: #422

@PragTob
Copy link
Member

PragTob commented Dec 23, 2023

Fixed by #422 !

@PragTob PragTob closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants