From 2bf94fafb388792cac2be1dd749b3af6037726d1 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Thu, 14 Nov 2024 12:53:23 -0500 Subject: [PATCH 01/17] init windows CI --- .github/workflows/ci_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 7c62dd5..2f5aeaa 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -31,7 +31,7 @@ jobs: strategy: fail-fast: false matrix: - platform: [ubuntu-latest] + platform: [ubuntu-latest, windows-latest] compiler: - cpp: g++ c: gcc From 37fe7ce239aa9b43cbe0acebf3248ace4407057e Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Thu, 14 Nov 2024 13:07:27 -0500 Subject: [PATCH 02/17] update config --- .github/workflows/ci_tests.yml | 45 +++++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 2f5aeaa..0b2e72b 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -31,12 +31,19 @@ jobs: strategy: fail-fast: false matrix: - platform: [ubuntu-latest, windows-latest] - compiler: - - cpp: g++ + platform: + - description: "ubuntu gcc" + cpp: g++ c: gcc - - cpp: clang++ + os: ubuntu-latest + - description: "ubuntu clang" + cpp: clang++ c: clang + os: ubuntu-latest + - description: "windows MSVC" + cpp: cl + c: cl + os: windows-latest cpp_version: [17, 20, 23, 26] cmake_args: - description: "Default" @@ -46,25 +53,27 @@ jobs: - description: "ASan" args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'" include: - - platform: ubuntu-latest - compiler: + - platform: + description: "ubuntu gcc" cpp: g++ c: gcc + os: ubuntu-latest cpp_version: 17 cmake_args: description: "Werror" args: "-DCMAKE_CXX_FLAGS='-Werror=all -Werror=extra'" - - platform: ubuntu-latest - compiler: + - platform: + description: "ubuntu gcc" cpp: g++ c: gcc + os: ubuntu-latest cpp_version: 17 cmake_args: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" - name: "Unit: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}" - runs-on: ${{ matrix.platform }} + name: "Unit: ${{ matrix.platform.description }} ${{ matrix.cmake_args.description }}" + runs-on: ${{ matrix.platform.os }} steps: - uses: actions/checkout@v4 - name: Install Ninja @@ -72,18 +81,26 @@ jobs: with: cmakeVersion: "~3.25.0" ninjaVersion: "^1.11.1" + - name: Setup MSVC + if: startsWith(matrix.platform.os, 'windows') + uses: TheMrMilchmann/setup-msvc-dev@v3 + with: + arch: x64 - name: Print installed softwares run: | - clang++ --version - g++ --version + echo "Compiler:" + ${{ matrix.platform.cpp }} --version + ${{ matrix.platform.c }} --version + + echo "Build system:" cmake --version ninja --version - name: Configure CMake run: | cmake -B build -S . -DCMAKE_CXX_STANDARD=${{ matrix.cpp_version }} ${{ matrix.cmake_args.args }} env: - CC: ${{ matrix.compiler.c }} - CXX: ${{ matrix.compiler.cpp }} + CC: ${{ matrix.platform.c }} + CXX: ${{ matrix.platform.cpp }} CMAKE_GENERATOR: "Ninja Multi-Config" - name: Build Release run: | From 625f140a5455914745153936bb2579c3e3fe8ef7 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Thu, 14 Nov 2024 13:15:35 -0500 Subject: [PATCH 03/17] temp find -> tree --- .github/workflows/ci_tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 0b2e72b..949a59b 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -72,7 +72,7 @@ jobs: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" - name: "Unit: ${{ matrix.platform.description }} ${{ matrix.cmake_args.description }}" + name: "Unit: ${{ matrix.platform.description }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}" runs-on: ${{ matrix.platform.os }} steps: - uses: actions/checkout@v4 @@ -107,7 +107,7 @@ jobs: cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets cmake --install build --config Release --prefix /opt/beman.exemplar - find /opt/beman.exemplar -type f + tree /opt/beman.exemplar - name: Test Release run: ctest --test-dir build --build-config Release - name: Build Debug @@ -115,7 +115,7 @@ jobs: cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix /opt/beman.exemplar - find /opt/beman.exemplar -type f + tree /opt/beman.exemplar - name: Test Debug run: ctest --test-dir build --build-config Debug From 1bd90555317f47a7b2b108b4afef853700d5e13c Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Tue, 19 Nov 2024 15:23:17 -0500 Subject: [PATCH 04/17] ugly workaround --- .github/workflows/ci_tests.yml | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 949a59b..a0b01e4 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -40,10 +40,6 @@ jobs: cpp: clang++ c: clang os: ubuntu-latest - - description: "windows MSVC" - cpp: cl - c: cl - os: windows-latest cpp_version: [17, 20, 23, 26] cmake_args: - description: "Default" @@ -71,6 +67,25 @@ jobs: cmake_args: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" + - platform: + description: "windows MSVC" + cpp: cl + c: cl + os: windows-latest + cpp_version: 17 + cmake_args: + description: "ASan" + args: "-DCMAKE_CXX_FLAGS=-fsanitize=address" + - platform: + description: "windows MSVC" + cpp: cl + c: cl + os: windows-latest + cpp_version: 17 + cmake_args: + description: "Default" + args: "" + name: "Unit: ${{ matrix.platform.description }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}" runs-on: ${{ matrix.platform.os }} From 8c4c8a488ca44982ef2ca36e06889248625118a3 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Tue, 19 Nov 2024 15:38:40 -0500 Subject: [PATCH 05/17] add debug info for msvc asan --- .github/workflows/ci_tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index a0b01e4..5369eb1 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -75,7 +75,9 @@ jobs: cpp_version: 17 cmake_args: description: "ASan" - args: "-DCMAKE_CXX_FLAGS=-fsanitize=address" + # Debug infomation needed to avoid cl: C5072 + # https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-c5072?view=msvc-170 + args: "-DCMAKE_CXX_FLAGS='/fsanitize=address /Zi'" - platform: description: "windows MSVC" cpp: cl From 47cc8296b0ece3f1753de70b2c9479b4c8ad10ce Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Tue, 19 Nov 2024 15:51:33 -0500 Subject: [PATCH 06/17] cleanup --- .github/workflows/ci_tests.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 5369eb1..d34f637 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -67,6 +67,8 @@ jobs: cmake_args: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" + # MSVC has limited support for sanitizers, so we use include here for MSVC as an exception. + # This should be simplified after beman-project/exemplar#76 is merged. - platform: description: "windows MSVC" cpp: cl @@ -74,10 +76,8 @@ jobs: os: windows-latest cpp_version: 17 cmake_args: - description: "ASan" - # Debug infomation needed to avoid cl: C5072 - # https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-c5072?view=msvc-170 - args: "-DCMAKE_CXX_FLAGS='/fsanitize=address /Zi'" + description: "Default" + args: "" - platform: description: "windows MSVC" cpp: cl @@ -85,8 +85,10 @@ jobs: os: windows-latest cpp_version: 17 cmake_args: - description: "Default" - args: "" + description: "ASan" + # Debug infomation needed to avoid cl: C5072 + # https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-c5072?view=msvc-170 + args: "-DCMAKE_CXX_FLAGS='/fsanitize=address /Zi'" name: "Unit: ${{ matrix.platform.description }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}" From 45e10056d5d6689e59841b10667524d43b574e39 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 15:23:53 -0500 Subject: [PATCH 07/17] Update .github/workflows/ci_tests.yml Co-authored-by: David Sankel --- .github/workflows/ci_tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index d34f637..ad3609c 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -126,7 +126,9 @@ jobs: cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets cmake --install build --config Release --prefix /opt/beman.exemplar - tree /opt/beman.exemplar + cd /opt/beman.exemplar + tree + cd - - name: Test Release run: ctest --test-dir build --build-config Release - name: Build Debug From 01bf5993dfbfc9959fb58bf30e4cc32fac284c88 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 15:32:42 -0500 Subject: [PATCH 08/17] Update .github/workflows/ci_tests.yml Co-authored-by: David Sankel --- .github/workflows/ci_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index ad3609c..3aa2689 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -108,8 +108,8 @@ jobs: - name: Print installed softwares run: | echo "Compiler:" - ${{ matrix.platform.cpp }} --version - ${{ matrix.platform.c }} --version + ${{ matrix.platform.cpp }} ${{ matrix.platform.cpp == 'cl' && '' || '--version' }} + ${{ matrix.platform.c }} ${{ matrix.platform.cpp == 'cl' && '' || '--version' }} echo "Build system:" cmake --version From ac89671644064968fe63c9570f96c30c3f22f2af Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 15:38:53 -0500 Subject: [PATCH 09/17] Update .github/workflows/ci_tests.yml Co-authored-by: David Sankel --- .github/workflows/ci_tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 3aa2689..ea125ca 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -67,8 +67,6 @@ jobs: cmake_args: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" - # MSVC has limited support for sanitizers, so we use include here for MSVC as an exception. - # This should be simplified after beman-project/exemplar#76 is merged. - platform: description: "windows MSVC" cpp: cl From 2230b3e57756bcffb5f3c939e54e56250ead8c70 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 18:37:51 -0500 Subject: [PATCH 10/17] Revert no --version on cl This reverts commit 01bf5993dfbfc9959fb58bf30e4cc32fac284c88. --- .github/workflows/ci_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index ea125ca..62f8cec 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -106,8 +106,8 @@ jobs: - name: Print installed softwares run: | echo "Compiler:" - ${{ matrix.platform.cpp }} ${{ matrix.platform.cpp == 'cl' && '' || '--version' }} - ${{ matrix.platform.c }} ${{ matrix.platform.cpp == 'cl' && '' || '--version' }} + ${{ matrix.platform.cpp }} --version + ${{ matrix.platform.c }} --version echo "Build system:" cmake --version From 7f774abdb8f1338718ed87cddb484bd5bdf1505a Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 18:46:14 -0500 Subject: [PATCH 11/17] use temporary directory for install --- .github/workflows/ci_tests.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 62f8cec..eb2b94c 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -123,18 +123,16 @@ jobs: run: | cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets - cmake --install build --config Release --prefix /opt/beman.exemplar - cd /opt/beman.exemplar - tree - cd - + cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar + tree ${{ runner.temp }}/beman.exemplar - name: Test Release run: ctest --test-dir build --build-config Release - name: Build Debug run: | cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets - cmake --install build --config Debug --prefix /opt/beman.exemplar - tree /opt/beman.exemplar + cmake --install build --config Debug --prefix ${{ runner.temp }}/beman.exemplar + tree ${{ runner.temp }}/beman.exemplar - name: Test Debug run: ctest --test-dir build --build-config Debug From e8f6417fcc22e20ec21c7d50c9e6414d808b3bbd Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 18:49:30 -0500 Subject: [PATCH 12/17] Use ls -R instead of tree for compatibility --- .github/workflows/ci_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index eb2b94c..35bf23d 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -124,7 +124,7 @@ jobs: cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar - tree ${{ runner.temp }}/beman.exemplar + ls -R ${{ runner.temp }}/beman.exemplar - name: Test Release run: ctest --test-dir build --build-config Release - name: Build Debug @@ -132,7 +132,7 @@ jobs: cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix ${{ runner.temp }}/beman.exemplar - tree ${{ runner.temp }}/beman.exemplar + ls -R ${{ runner.temp }}/beman.exemplar - name: Test Debug run: ctest --test-dir build --build-config Debug From 2286fa6d7f176ca1869127499c435e37ef5954b0 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 19:35:12 -0500 Subject: [PATCH 13/17] fix print software version for cl --- .github/workflows/ci_tests.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 35bf23d..627e286 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -104,10 +104,18 @@ jobs: with: arch: x64 - name: Print installed softwares + shell: bash run: | echo "Compiler:" - ${{ matrix.platform.cpp }} --version - ${{ matrix.platform.c }} --version + + # cl does not have a --version option + if [ "${{ matrix.platform.cpp }}" != "cl" ]; then + ${{ matrix.platform.cpp }} --version + ${{ matrix.platform.c }} --version + else + ${{ matrix.platform.cpp }} + ${{ matrix.platform.c }} + fi echo "Build system:" cmake --version From 84a7177e934a7f8cf5dc99e1f6a5b703be02b8eb Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 19:57:55 -0500 Subject: [PATCH 14/17] update configuration testing --- .github/workflows/ci_tests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 627e286..9ee0949 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -174,14 +174,15 @@ jobs: run: | cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets - cmake --install build --config Release --prefix /opt/beman.exemplar - find /opt/beman.exemplar -type f + cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar + ls -R ${{ runner.temp }}/beman.exemplar - name: Build Debug run: | cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix /opt/beman.exemplar - find /opt/beman.exemplar -type f + cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar + ls -R ${{ runner.temp }}/beman.exemplar create-issue-when-fault: runs-on: ubuntu-latest From 1a3c911d44cb2176c0b0084877d28800fe837436 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Wed, 4 Dec 2024 20:00:07 -0500 Subject: [PATCH 15/17] revert back to use /opt/beman.exemplar --- .github/workflows/ci_tests.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 9ee0949..519db17 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -131,16 +131,16 @@ jobs: run: | cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets - cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar - ls -R ${{ runner.temp }}/beman.exemplar + cmake --install build --config Release --prefix /opt/beman.exemplar + ls -R /opt/beman.exemplar - name: Test Release run: ctest --test-dir build --build-config Release - name: Build Debug run: | cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets - cmake --install build --config Debug --prefix ${{ runner.temp }}/beman.exemplar - ls -R ${{ runner.temp }}/beman.exemplar + cmake --install build --config Debug --prefix /opt/beman.exemplar + ls -R /opt/beman.exemplar - name: Test Debug run: ctest --test-dir build --build-config Debug @@ -174,15 +174,14 @@ jobs: run: | cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets - cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar - ls -R ${{ runner.temp }}/beman.exemplar + cmake --install build --config Release --prefix /opt/beman.exemplar + ls -R /opt/beman.exemplar - name: Build Debug run: | cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix /opt/beman.exemplar - cmake --install build --config Release --prefix ${{ runner.temp }}/beman.exemplar - ls -R ${{ runner.temp }}/beman.exemplar + ls -R /opt/beman.exemplar create-issue-when-fault: runs-on: ubuntu-latest From fe6fc4500857128a15ebe8ab846981d145389efc Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Thu, 5 Dec 2024 17:06:58 -0500 Subject: [PATCH 16/17] add comment --- .github/workflows/ci_tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 519db17..1cd3869 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -129,6 +129,7 @@ jobs: CMAKE_GENERATOR: "Ninja Multi-Config" - name: Build Release run: | + # Portable commands only cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets cmake --install build --config Release --prefix /opt/beman.exemplar @@ -137,6 +138,7 @@ jobs: run: ctest --test-dir build --build-config Release - name: Build Debug run: | + # Portable commands only cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix /opt/beman.exemplar @@ -172,12 +174,14 @@ jobs: CMAKE_GENERATOR: "Ninja Multi-Config" - name: Build Release run: | + # Portable commands only cmake --build build --config Release --verbose cmake --build build --config Release --target all_verify_interface_header_sets cmake --install build --config Release --prefix /opt/beman.exemplar ls -R /opt/beman.exemplar - name: Build Debug run: | + # Portable commands only cmake --build build --config Debug --verbose cmake --build build --config Debug --target all_verify_interface_header_sets cmake --install build --config Debug --prefix /opt/beman.exemplar From bdb06fc9f3e5fdd5730a87cd5a032216e7536ec7 Mon Sep 17 00:00:00 2001 From: River <26424577+wusatosi@users.noreply.github.com> Date: Thu, 5 Dec 2024 17:10:28 -0500 Subject: [PATCH 17/17] capitalize description --- .github/workflows/ci_tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index 1cd3869..e340bf4 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -32,11 +32,11 @@ jobs: fail-fast: false matrix: platform: - - description: "ubuntu gcc" + - description: "Ubuntu GCC" cpp: g++ c: gcc os: ubuntu-latest - - description: "ubuntu clang" + - description: "Ubuntu Clang" cpp: clang++ c: clang os: ubuntu-latest @@ -50,7 +50,7 @@ jobs: args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'" include: - platform: - description: "ubuntu gcc" + description: "Ubuntu GCC" cpp: g++ c: gcc os: ubuntu-latest @@ -59,7 +59,7 @@ jobs: description: "Werror" args: "-DCMAKE_CXX_FLAGS='-Werror=all -Werror=extra'" - platform: - description: "ubuntu gcc" + description: "Ubuntu GCC" cpp: g++ c: gcc os: ubuntu-latest @@ -68,7 +68,7 @@ jobs: description: "Dynamic" args: "-DBUILD_SHARED_LIBS=on" - platform: - description: "windows MSVC" + description: "Windows MSVC" cpp: cl c: cl os: windows-latest @@ -77,7 +77,7 @@ jobs: description: "Default" args: "" - platform: - description: "windows MSVC" + description: "Windows MSVC" cpp: cl c: cl os: windows-latest