-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Beman.InplaceVector #37
Comments
Hi, @camio. I'd be interested in implementing this for Beman, but first I have to ask: what c++ knowledge is required? Would help from someone who's not professional still be accepted or you are looking for someone with more experience? |
Hey @Hels15! For this task, I think intermediate C++ competence would be helpful, but don't worry about asking "beginner" questions. We all start somewhere and are happy to help. |
In that case I would be happy to take on the project. |
Awesome! In that case you should be able to create an InplaceVector repository in the beman-project org and start populating it. Feel free to ask questions in the Beman discourse. |
Thank you, I'm wondering if @gnzblg is a valid username on Git Hub, as I can't seem to find any reference to the person who offered the help for mentorship. |
Also my other question: Is it good enough if the implementation matches with the ones that you sent before, or there are some improvements that we are trying to make that differ from the current implementations? |
I think you could probably use those implementations directly. You can check to make sure they match the specification of the paper and just put them in the Beman format. @gnzblg is Gonzalo Brito, the primary author of the paper. https://github.com/gnzlbg |
@camio I have a pr here for review, if I'm not mistaken you said that Gonzalo Brito offered his help to review the possible implementations: beman-project/inplace_vector#1 |
Since this is well underway should we close this issue |
Makes sense to me. Closing |
This task is to create a new Beman.InplaceVector library implementing Gonzalo Brito Gadeschi et. all's
inplace_vector
paper.There is a production-quality here licensed under Apache-2.0 WITH LLVM-exception that would be a good start. Another non-production-quality implementation is here.
@gnzblg offered to mentor anyone who wants to take this up.
The text was updated successfully, but these errors were encountered: