Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Beman.InplaceVector #37

Closed
camio opened this issue Aug 1, 2024 · 10 comments
Closed

Implement Beman.InplaceVector #37

camio opened this issue Aug 1, 2024 · 10 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@camio
Copy link
Contributor

camio commented Aug 1, 2024

This task is to create a new Beman.InplaceVector library implementing Gonzalo Brito Gadeschi et. all's inplace_vector paper.

There is a production-quality here licensed under Apache-2.0 WITH LLVM-exception that would be a good start. Another non-production-quality implementation is here.

@gnzblg offered to mentor anyone who wants to take this up.

@camio camio added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 1, 2024
@Hels15
Copy link

Hels15 commented Aug 2, 2024

Hi, @camio. I'd be interested in implementing this for Beman, but first I have to ask: what c++ knowledge is required? Would help from someone who's not professional still be accepted or you are looking for someone with more experience?

@camio
Copy link
Contributor Author

camio commented Aug 2, 2024

Hey @Hels15! For this task, I think intermediate C++ competence would be helpful, but don't worry about asking "beginner" questions. We all start somewhere and are happy to help.

@Hels15
Copy link

Hels15 commented Aug 2, 2024

Hey @Hels15! For this task, I think intermediate C++ competence would be helpful, but don't worry about asking "beginner" questions. We all start somewhere and are happy to help.

In that case I would be happy to take on the project.

@camio
Copy link
Contributor Author

camio commented Aug 2, 2024

Awesome! In that case you should be able to create an InplaceVector repository in the beman-project org and start populating it. Feel free to ask questions in the Beman discourse.

@Hels15
Copy link

Hels15 commented Aug 3, 2024

Awesome! In that case, you should be able to create an InplaceVector repository in the beman-project org and start populating it. Feel free to ask questions in the Beman discourse.

Thank you, I'm wondering if @gnzblg is a valid username on Git Hub, as I can't seem to find any reference to the person who offered the help for mentorship.

@Hels15
Copy link

Hels15 commented Aug 3, 2024

Also my other question: Is it good enough if the implementation matches with the ones that you sent before, or there are some improvements that we are trying to make that differ from the current implementations?

@camio
Copy link
Contributor Author

camio commented Aug 5, 2024

I think you could probably use those implementations directly. You can check to make sure they match the specification of the paper and just put them in the Beman format. @gnzblg is Gonzalo Brito, the primary author of the paper. https://github.com/gnzlbg

@camio camio removed the help wanted Extra attention is needed label Aug 9, 2024
@Hels15
Copy link

Hels15 commented Aug 16, 2024

@camio I have a pr here for review, if I'm not mistaken you said that Gonzalo Brito offered his help to review the possible implementations: beman-project/inplace_vector#1

@JeffGarland
Copy link
Contributor

Since this is well underway should we close this issue

@camio
Copy link
Contributor Author

camio commented Sep 16, 2024

Makes sense to me. Closing

@camio camio closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants