Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor clone package #367

Open
carreter opened this issue Sep 23, 2023 · 5 comments
Open

Refactor clone package #367

carreter opened this issue Sep 23, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix stale ux Issues with user experience of using the package

Comments

@carreter
Copy link
Collaborator

carreter commented Sep 23, 2023

Per @Koeng101 's suggestion, the clone package needs some refactoring to make its code easier to understand and use.

Blocks #359 .

@carreter carreter converted this from a draft issue Sep 23, 2023
@carreter carreter added enhancement New feature or request ux Issues with user experience of using the package high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix labels Sep 23, 2023
Copy link

This issue has had no activity in the past 2 months. Marking as stale.

@carreter
Copy link
Collaborator Author

Reopening this because the clone package still needs a good amount of work. Thinking of spending a significant amount of time on this during the first half of January, as most of the scripts I will be writing for Prof. Weiss' lab will be related to cloning.

@TwFlem would love to get your input on what you think needs to be done. You mentioned seqhash needing some optimization - I bet we could just look at recently published algos and make our own implementation. I'd also like to rewrite the structs that hold the data on DNA parts/fragments to make them more flexible and properly encode 3' vs 5' overhangs.

@github-actions github-actions bot removed the stale label Dec 20, 2023
@TwFlem
Copy link
Contributor

TwFlem commented Dec 21, 2023

@carreter I mentioned the seqhash performance in #393 because the bug fix was related to concurrent code. Before removing it, I did some profiling to make sure it didn't cause any issues. It turns out removing the concurrency was a speedup. I only mentioned improving seqhash just in case if we needed cloning to be faster.

Unless Poly consumers are currently raising concerns about performance, I would not say seqhash is fine the way it currently is.

@carreter carreter self-assigned this Jan 9, 2024
@carreter
Copy link
Collaborator Author

carreter commented Jan 9, 2024

This is gonna be high-priority for me this January as I will be working to facilitate the cloning workflow of Fabio Caliendo in Prof. Ron Weiss' lab.

Currently blocks #359 .

Copy link

github-actions bot commented Mar 9, 2024

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix stale ux Issues with user experience of using the package
Projects
None yet
Development

No branches or pull requests

3 participants