-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Loki Log Streaming #1385
base: main
Are you sure you want to change the base?
feat: Loki Log Streaming #1385
Conversation
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
227c6a2
to
592789b
Compare
Rebased and resolved package conflicts |
@amanji there's a pull request here that refactors some startup to a |
Let's give it a try. I doubt there will be a huge impact |
Deployment URLs ready for review. |
bea4259
to
c8e0a77
Compare
Signed-off-by: Akiff Manji <[email protected]>
c8e0a77
to
48818a4
Compare
Signed-off-by: Akiff Manji <[email protected]>
@i5okie do you have any suggestiono n how to set things up for the supporting services? i.e.: we list them as pre-requisites or do we include (optional) depenedncies in the Helm chart? |
In my opinion, I think Traction should work without throwing exceptions or failing when it runs without Loki backend being configured. As such, I think Loki should be an optional component setup separately by the user. I'd imagine, if loki endpoint is not provided/log-streaming is disabled, the feature should be turned off in someway. Or at least say logs unavailable in a friendly (not app crashing) manner on the page. As for the |
Signed-off-by: Akiff Manji <[email protected]>
- SERVER_LOKI_URL=${SERVER_LOKI_URL} | ||
- FRONTEND_TENANT_PROXY_URL=${FRONTEND_TENANT_PROXY_URL} | ||
- FRONTEND_LOG_STREAM_URL=${FRONTEND_LOG_STREAM_URL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These envvars
need to be added to the chart as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See chart if its correct.
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
I'll update the PR to hide the log feature when the |
No description provided.