From 78ee27b68ee5c88445b277a6df7988e4f4cc5814 Mon Sep 17 00:00:00 2001
From: abradat <shn.khorsandi@gmail.com>
Date: Mon, 12 Aug 2024 12:19:45 -0700
Subject: [PATCH] Fix ALCS advance search date range bugs for Applications,
 NOIs, and SRWs

---
 .../application-advanced-search.service.ts            |  4 ++--
 .../notice-of-intent-advanced-search.service.ts       |  6 +++---
 .../notification-advanced-search.service.ts           | 11 ++++++++---
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/services/apps/alcs/src/alcs/search/application/application-advanced-search.service.ts b/services/apps/alcs/src/alcs/search/application/application-advanced-search.service.ts
index 1c4279235..43ebd8009 100644
--- a/services/apps/alcs/src/alcs/search/application/application-advanced-search.service.ts
+++ b/services/apps/alcs/src/alcs/search/application/application-advanced-search.service.ts
@@ -269,7 +269,7 @@ export class ApplicationAdvancedSearchService {
     }
 
     if (searchDto.dateSubmittedTo !== undefined) {
-      query.andWhere('app.date_submitted_to_alc <= :date_submitted_to', {
+      query.andWhere('app.date_submitted_to_alc < :date_submitted_to', {
         date_submitted_to: getNextDayToPacific(
           searchDto.dateSubmittedTo,
         ).toISOString(),
@@ -300,7 +300,7 @@ export class ApplicationAdvancedSearchService {
     }
 
     if (searchDto.dateDecidedTo) {
-      query.andWhere('decision.date <= :decision_date_to', {
+      query.andWhere('decision.date < :decision_date_to', {
         decision_date_to: getNextDayToPacific(
           searchDto.dateDecidedTo,
         ).toISOString(),
diff --git a/services/apps/alcs/src/alcs/search/notice-of-intent/notice-of-intent-advanced-search.service.ts b/services/apps/alcs/src/alcs/search/notice-of-intent/notice-of-intent-advanced-search.service.ts
index 7fa790d0b..b3611eba2 100644
--- a/services/apps/alcs/src/alcs/search/notice-of-intent/notice-of-intent-advanced-search.service.ts
+++ b/services/apps/alcs/src/alcs/search/notice-of-intent/notice-of-intent-advanced-search.service.ts
@@ -287,7 +287,7 @@ export class NoticeOfIntentAdvancedSearchService {
         {
           date_submitted_from: getStartOfDayToPacific(
             searchDto.dateSubmittedFrom,
-          ),
+          ).toISOString(),
         },
       );
     }
@@ -298,7 +298,7 @@ export class NoticeOfIntentAdvancedSearchService {
         {
           date_submitted_to: getNextDayToPacific(
             searchDto.dateSubmittedTo,
-          ),
+          ).toISOString(),
         },
       );
     }
@@ -327,7 +327,7 @@ export class NoticeOfIntentAdvancedSearchService {
     }
 
     if (searchDto.dateDecidedTo) {
-      query = query.andWhere('decision.date <= :decision_date_to', {
+      query = query.andWhere('decision.date < :decision_date_to', {
         decision_date_to: getNextDayToPacific(
           searchDto.dateDecidedTo,
         ).toISOString(),
diff --git a/services/apps/alcs/src/alcs/search/notification/notification-advanced-search.service.ts b/services/apps/alcs/src/alcs/search/notification/notification-advanced-search.service.ts
index 3ea1d8997..6e0c3b0b3 100644
--- a/services/apps/alcs/src/alcs/search/notification/notification-advanced-search.service.ts
+++ b/services/apps/alcs/src/alcs/search/notification/notification-advanced-search.service.ts
@@ -11,6 +11,7 @@ import { Notification } from '../../notification/notification.entity';
 import { SEARCH_CACHE_TIME } from '../search.config';
 import { AdvancedSearchResultDto, SearchRequestDto } from '../search.dto';
 import { NotificationSubmissionSearchView } from './notification-search-view.entity';
+import { getNextDayToPacific, getStartOfDayToPacific } from '../../../utils/pacific-date-time-helper';
 
 @Injectable()
 export class NotificationAdvancedSearchService {
@@ -210,16 +211,20 @@ export class NotificationAdvancedSearchService {
       query = query.andWhere(
         'notification.date_submitted_to_alc >= :date_submitted_from',
         {
-          date_submitted_from: new Date(searchDto.dateSubmittedFrom),
+          date_submitted_from: getStartOfDayToPacific(
+            searchDto.dateSubmittedFrom
+          ).toISOString(),
         },
       );
     }
 
     if (searchDto.dateSubmittedTo !== undefined) {
       query = query.andWhere(
-        'notification.date_submitted_to_alc <= :date_submitted_to',
+        'notification.date_submitted_to_alc < :date_submitted_to',
         {
-          date_submitted_to: new Date(searchDto.dateSubmittedTo),
+          date_submitted_to: getNextDayToPacific(
+            searchDto.dateSubmittedTo
+          ).toISOString(),
         },
       );
     }