Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For httprb adapter, it should raise NetConnectNotAllowedError if connect is not allowed. #1089

Open
Novtopro opened this issue Jan 5, 2025 · 0 comments · May be fixed by #1090
Open

For httprb adapter, it should raise NetConnectNotAllowedError if connect is not allowed. #1089

Novtopro opened this issue Jan 5, 2025 · 0 comments · May be fixed by #1090

Comments

@Novtopro
Copy link

Novtopro commented Jan 5, 2025

If connect is not allowed, for httprb adapter, it will just return nil. I think we should raise a NetConnectNotAllowedError just like other adapters.

Novtopro pushed a commit to Novtopro/webmock that referenced this issue Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant