Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete implementation of android dynamic features #254

Open
oliviernotteghem opened this issue Aug 16, 2024 · 5 comments
Open

Incomplete implementation of android dynamic features #254

oliviernotteghem opened this issue Aug 16, 2024 · 5 comments

Comments

@oliviernotteghem
Copy link

We're migrating our Android codebase to Bazel, and are using android dynamic features module containing resources, assets and bytecode.

However, bytecode in dynamic feature is not supported at the moment. See comment : the android_library contained in this split. Must only contain assets.

It's unclear if android resources are supported either.

@timpeut
Copy link
Collaborator

timpeut commented Aug 16, 2024

We currently only support assets and native libraries. Bytecode and resources are not supported.

@oliviernotteghem
Copy link
Author

@timpeut : any plans to supporting these anytime soon? I don't see this item on rules_android roadmap..

And, just out of curiosity, what is the rationale for providing an impl that supports only native libs and assets?

@timpeut
Copy link
Collaborator

timpeut commented Aug 16, 2024

There are no current plans to add support. We decided that native libs and assets provided a good balance of implementation complexity and potential size savings (especially as apps are looking to incorporate ML models etc which can be large). Proper support for bytecode is more complex and isn't something we've needed to prioritize.

@oliviernotteghem
Copy link
Author

Alright, we need resources + bytecode support in dynamic feature and are possibly opened to build it. Who would be a good contact to provide guidance how to build it?

@oliviernotteghem
Copy link
Author

cc @ahumesky @ted-xie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants