Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that java_tools are built in a UTF-8 enabled locale #25158

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ensure that java_tools are built in a UTF-8 enabled locale #25158

wants to merge 5 commits into from
+30 −0

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 31, 2025 •
edited
Loading

Work towards #24444

@fmeum fmeum requested a review from meteorcloudy January 31, 2025 14:26
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 31, 2025
@meteorcloudy meteorcloudy requested a review from hvadehra January 31, 2025 15:21
meteorcloudy
meteorcloudy approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @hvadehra should also take a look

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 31, 2025
@meteorcloudy
Copy link
Member

This change has been verified at https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/274#_

@fmeum fmeum mentioned this pull request Jan 31, 2025
Open
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 31, 2025

@hvadehra Sorry for the churn, but could you and @iancha1992 create a new java_tools release after this has been merged? I created bazelbuild/rules_java#270.

@iancha1992
Copy link
Member

@fmeum could you please add the javadoc comment for src/CheckSunJnuEncoding.java? Thanks!

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 31, 2025

@fmeum could you please add the javadoc comment for src/CheckSunJnuEncoding.java? Thanks!

Done!

@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@hvadehra hvadehra hvadehra approved these changes

Assignees
No one assigned
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmeum @meteorcloudy @iancha1992 @hvadehra @sgowroji