Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python test base doesn't set up runfiles properly #182

Open
katre opened this issue Aug 24, 2023 · 1 comment
Open

Python test base doesn't set up runfiles properly #182

katre opened this issue Aug 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@katre
Copy link
Collaborator

katre commented Aug 24, 2023

Any test that uses runfiles and the Python integration test framework will see errors because the environment variables aren't set up properly.

katre added a commit to katre/rules_bazel_integration_test that referenced this issue Aug 24, 2023
Windows runfile support is sufficiently different that it will need a
different mechanism.

Part of bazel-contrib#182.
@katre
Copy link
Collaborator Author

katre commented Aug 24, 2023

The fix for non-Windows is simple, but Windows runfile support is sufficiently different that it will need more work. Added a TODO for this branch.

@cgrindel cgrindel added the bug Something isn't working label Aug 25, 2023
cgrindel added a commit that referenced this issue Aug 25, 2023
Windows runfile support is sufficiently different that it will need a
different mechanism.

Part of #182.

Co-authored-by: Chuck Grindel <[email protected]>
cgrindel added a commit to k1nkreet/rules_bazel_integration_test that referenced this issue Sep 27, 2023
Windows runfile support is sufficiently different that it will need a
different mechanism.

Part of bazel-contrib#182.

Co-authored-by: Chuck Grindel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants