Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bzlmod support to use bazel_versions.bzl and reduce boilerplate #125

Closed
Tracked by #120
cgrindel opened this issue Mar 14, 2023 · 1 comment · Fixed by #132
Closed
Tracked by #120

Update bzlmod support to use bazel_versions.bzl and reduce boilerplate #125

cgrindel opened this issue Mar 14, 2023 · 1 comment · Fixed by #132
Labels
chore Code cleanup or refactor

Comments

@cgrindel
Copy link
Member

cgrindel commented Mar 14, 2023 •
edited
Loading

Context and Ideas

Related to #120.
@cgrindel cgrindel added the chore Code cleanup or refactor label Mar 14, 2023
This was referenced Mar 14, 2023
Closed
Merged
cgrindel added a commit that referenced this issue Mar 16, 2023
@cgrindel
chore: implement hub-and-spoke for bazel binary downloads (#128)
f31adb8 
- Add `.bcr` folder with requisite files.
- Generate hub repository to aid in the resolution of the Bazel binary
repositories.
- Add `workspace_bazel_binaries` rule to allow repositories that use
`rules_bazel_integration_test` to work with and without bzlmod enabled.

Inspired by bazel-contrib/bazel-gazelle#1423.
Related to #125.
@cgrindel
Copy link
Member Author

Opted to have bazel_binaries provide a versions struct that provides current, other, and all.

@cgrindel cgrindel mentioned this issue Mar 16, 2023
Merged
cgrindel added a commit that referenced this issue Mar 16, 2023
@cgrindel
feat: expose version values via bazel_binaries.versions (#132)
0ae1e07 
Clients that are using bzlmod now only need to specify the Bazel
versions in their `MODULE.bazel`. The `bazel_versions.bzl` is no longer
necessary.
- Update `bazel_binaries` to provide the version information.
- Update `workspace_bazel_binaries` to consume the version info so that
it can also provide it.

Closes #125.
cgrindel added a commit to k1nkreet/rules_bazel_integration_test that referenced this issue Sep 27, 2023
@cgrindel
chore: implement hub-and-spoke for bazel binary downloads (bazel-cont…
d574dbe 
…rib#128)

- Add `.bcr` folder with requisite files.
- Generate hub repository to aid in the resolution of the Bazel binary
repositories.
- Add `workspace_bazel_binaries` rule to allow repositories that use
`rules_bazel_integration_test` to work with and without bzlmod enabled.

Inspired by bazel-contrib/bazel-gazelle#1423.
Related to bazel-contrib#125.
cgrindel added a commit to k1nkreet/rules_bazel_integration_test that referenced this issue Sep 27, 2023
@cgrindel
feat: expose version values via bazel_binaries.versions (bazel-cont…
d53cd70 
…rib#132)

Clients that are using bzlmod now only need to specify the Bazel
versions in their `MODULE.bazel`. The `bazel_versions.bzl` is no longer
necessary.
- Update `bazel_binaries` to provide the version information.
- Update `workspace_bazel_binaries` to consume the version info so that
it can also provide it.

Closes bazel-contrib#125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Code cleanup or refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose version values via bazel_binaries.versions bazel-contrib/rules_bazel_integration_test
1 participant
@cgrindel