Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acking retrieved messages from mailbox #236

Open
Relrin opened this issue Jul 17, 2020 · 0 comments
Open

Acking retrieved messages from mailbox #236

Relrin opened this issue Jul 17, 2020 · 0 comments
Labels
A-routing Area: Message routing internals C-feature-compat Category: Feature Compatibility C-feature-request Category: Feature Request

Comments

@Relrin
Copy link
Member

Relrin commented Jul 17, 2020

Is your feature request related to a problem? Please describe.
For the autoscaling feature (PR #202) would be great to have an ack mechanism for the processed message, that could help eliminate an issues around dropping actors that took the message but the executed future in the pending state.

Describe the solution you'd like
For any message, whatever its type and method that was used for getting a message from the queue, we always have to acknowledge (let's call just it as the ack call) the processed message or to skip it.

Benefits of the usage:

  • Actors can retrieve messages with the Exactly-Once guarantees
  • More reliable mechanism for tracking the current state of the actors and systems based on Bastion codebase

Possible ways to implement it:

  • Extend the implementation for the SignedMessage: add the ack / acknowledge method for confirming that the message was processed and can be removed from the mailbox.
  • Add the message_processed method for the BastionContext struct, that can be called inside of the actor's future

Describe alternatives you've considered
N/A

@Relrin Relrin mentioned this issue Jul 17, 2020
@vertexclique vertexclique added A-routing Area: Message routing internals C-feature-compat Category: Feature Compatibility C-feature-request Category: Feature Request labels Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-routing Area: Message routing internals C-feature-compat Category: Feature Compatibility C-feature-request Category: Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants