Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_known_ipaddrs_of_cluster adds empty clusters to the cluster manager state [JIRA: RIAK-2354] #721

Open
ian-mi opened this issue Jan 14, 2016 · 0 comments

Comments

@ian-mi
Copy link
Contributor

ian-mi commented Jan 14, 2016

Every call of get_known_ipaddrs_of_cluster reorders the members of the cluster in the cluster manager state. I seems somewhat questions that this function modifies the state at all, but it should at least leave the state unchanged modulo the the order of the cluster's members. However, when called on a cluster which is not currently known to the connection manager, that cluster will be added to the connection manager state with no members. Instead I think the state should simply be left unchanged.

This issue manifests itself when stale connections caused disconnected cluster to be readded to the cluster manager state as the riak_repl locator calls get_known_ipaddrs_of_cluster. This can cause the cluster to reappear in the riak-repl status immediately after calling riak-repl disconnect.

@Basho-JIRA Basho-JIRA changed the title get_known_ipaddrs_of_cluster adds empty clusters to the cluster manager state get_known_ipaddrs_of_cluster adds empty clusters to the cluster manager state [JIRA: RIAK-2354] Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants