Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry doesn't blow away the build dir, should it ? #60

Closed
davidx opened this issue Dec 8, 2016 · 2 comments
Closed

Retry doesn't blow away the build dir, should it ? #60

davidx opened this issue Dec 8, 2016 · 2 comments

Comments

@davidx
Copy link
Contributor

davidx commented Dec 8, 2016

When calling 'thumbot retry' it operates on the same build dir.
Some builds don't clean up to a pristine state before each build and thus a case could be made for blowing away the build dir entirely for it to be fresh.

This build: basho/riak_repl#764 (comment) had to be manually cleaned up for retry.

Should we blow away the build dir during retries ?

@JeetKunDoug
Copy link

I would say "yes" - the most typical case that I've run across is when Github fails to let you clone some repository, but git creates the directory - get-deps or some other step in the build process will then continue to fail until you delete at least that directory and do get-deps again.

@davidx
Copy link
Contributor Author

davidx commented Dec 9, 2016

Merged and deployed: #61

@davidx davidx closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants