Data structure name has a different colour to a standalone field

[richardm90]

I'm not sure if this is deliberate but a data structure variable name is shown as a different colour to a standalone field name. I tend to use the a light modern theme where the difference is barely noticeable but when using the dark modern theme it becomes more obvious.

If I add a freeidentifiers include into the pattern I get the colours I was expecting.

I've not played around with more complex examples yet as I first wanted to check this wasn't deliberate - I know some of the complex patterns handle more than just data structures i.e. procedures, prototypes, etc.

[barrettotte]

Weird, yeah there's something that I need to change with this. I always develop with the Monokai theme and naively thought the colors would have consistent behavior across themes, but clearly that's not the case.

Here's the example in Monokai:

I will look into fixing this up and also click around on different themes.
Thanks for bringing this to my attention

[richardm90]

I'm pretty sure that it's not the theme itself that is causing the problem. I just think it's more obvious when I swapped to a dark theme.

I could solve the problem but I had to change the code for the pattern to include freeIdentifiers.

Did you need to make any changes to the extension for the image you took in Monokai?

[barrettotte]

Did you need to make any changes to the extension for the image you took in Monokai?

No, my screenshot was the extension without changes.

[richardm90]

OK, that wasn't the answer I was expecting and these are the results I get.

Monokai (the same result as you):

Dark Modern (you can easily see the difference in colours):

Light Modern (you can just notice a difference in the colors):

The quick change I made to syntaxes/rpgle.tmLanguaga.json to see if it would fix the problem (not the full solution).

The results with my fix in place.

Monokai (no noticable difference):

Dark Modern (fixed):

Light Modern (fixed):

[barrettotte]

While throwing #freeIdentifiers in fixes your particular problem, it does break a handful of the manual tests in tests/ (137.rpgle, 115.rpgle, 29.rpgle) with Monokai; I didn't check the other themes yet. This is due to the regex for #freeIdentifiers consuming tokens that other regex needs.

Clicking through other themes without the change shows the same inconsistency between Monokai vs Dark Modern. Which leads me to think Monokai is the odd one out here.

I suspect I need to change some of the naming prefixes for the regex and confirm it has consistent behavior across all themes without regressing the highlighting of the prior tests.
Additionally, the other languages probably need to be checked across themes for sanity.