Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in code that computes the weighs based on the mask #77

Open
2006pmach opened this issue Dec 7, 2018 · 0 comments
Open

Bug in code that computes the weighs based on the mask #77

2006pmach opened this issue Dec 7, 2018 · 0 comments

Comments

@2006pmach
Copy link

Hi,

I noticed a bug in you implementation of the function def weight_context(self, mask):
Although you claim in the comment that the

#sliding window size is 7

you use in fact a window size of 6 as indexing an array in numpy with array[i-3:i+3] returns the values at i-3, i-2,i-1, i ,i+1, i+2 and does not include i+3. Thus, you are using a window size of 6 which is not centrally symmetric and puts different weights for pixels/holes on the right than on the left or bellow than above. So just add the +1 to all the corresponding lines...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant