Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAL-1957 #2374

Merged
merged 10 commits into from
May 27, 2024
Merged

BAL-1957 #2374

merged 10 commits into from
May 27, 2024

Conversation

chesterkmr
Copy link
Collaborator

@chesterkmr chesterkmr commented May 14, 2024 •
edited by coderabbitai bot
Loading

User description

Description

  • Updated context schema (added comment field)
  • Added comment input to document approval dialog
  • Updated decision endpoint
  • common bump

image

PR Type

enhancement

Description

  • Added support for handling comments in workflow decisions across various components and services.
  • Enhanced mutation functions and DTOs to include an optional comment parameter.
  • Updated schemas and internal logic to accommodate the new comment field.

Changes walkthrough 📝

Relevant files
Enhancement
useApproveTaskByIdMutation.tsx
Enhance Task Approval Mutation to Include Comments             

apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx

  • Added comment parameter to the mutation function for approving tasks.
  • Enhanced the mutation function to include comments when updating
    workflow decisions.
    		•  +6/-3     
    fetchers.ts
    Update Workflow Decision Fetcher to Support Comments         

    apps/backoffice-v2/src/domains/workflows/fetchers.ts

  • Reorganized imports and added new schemas for workflow definitions.
  • Updated updateWorkflowDecision function to handle an optional comment
    parameter.
    		•  +8/-7     
    useDocumentBlocks.tsx
    Add Comment Functionality to Document Blocks                         

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx

  • Integrated comment functionality in the document blocks for workflow
    actions.
  • Added state management for comment input.
    		•  +23/-3   
    default-context-schema.ts
    Extend Default Context Schema with Comment Field                 

    packages/common/src/schemas/documents/default-context-schema.ts

    • Added optional comment field to the default context schema.
    		 +1/-0     
    document-decision-update-input.ts
    Update Document Decision DTO to Include Comment Field       

    services/workflows-service/src/workflow/dtos/document-decision-update-input.ts

  • Added optional comment field to the document decision update DTO.
    		•  +5/-1     
    workflow.controller.internal.ts
    Update Workflow Controller to Handle Comment Data               

    services/workflows-service/src/workflow/workflow.controller.internal.ts

  • Updated controller to pass comment data through to the service layer.
    		•  +4/-3     
    workflow.service.ts
    Enhance Workflow Service to Process Comment Data                 

    services/workflows-service/src/workflow/workflow.service.ts

  • Enhanced service logic to handle comment data when processing workflow
    decisions.
    		•  +4/-0     
    Miscellaneous
    useKycBlock.tsx
    Refactor Imports in KYC Block Hook                                             

    apps/backoffice-v2/src/lib/blocks/components/KycBlock/hooks/useKycBlock/useKycBlock.tsx

    • Minor import adjustments.
    		 +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Summary by CodeRabbit

    • New Features

      • Added the ability to include comments when approving tasks and updating workflow decisions.

    • Improvements

      • Updated dependencies across multiple applications for enhanced stability and performance.

    • Bug Fixes

      • Minor adjustments to import statements to ensure proper functionality.

    • Documentation

      • Updated changelogs to reflect the latest changes and dependency updates.

    @chesterkmr chesterkmr requested a review from Omri-Levy May 14, 2024 10:46
    @changeset-bot changeset-bot
    Copy link

    changeset-bot bot commented May 14, 2024 •
    edited
    Loading

    ⚠️ No Changeset found

    Latest commit: 3c903a5

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    @coderabbitai coderabbitai
    Copy link
    Contributor

    coderabbitai bot commented May 14, 2024 •
    edited
    Loading

    Walkthrough

    The recent changes introduce a new comment parameter to various parts of the application, allowing users to add comments when approving tasks or updating workflow decisions. This enhancement spans multiple files, including hooks, services, and components, ensuring that comments are properly handled and passed through the system. Additionally, several dependencies have been updated to their latest versions to ensure compatibility and improved functionality.

    Changes

    File(s) Summary of Changes
    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx Added comment parameter to mutationFn function.
    apps/backoffice-v2/src/domains/workflows/fetchers.ts Added comment field to updateWorkflowDecision function and updated imports.
    apps/backoffice-v2/src/lib/blocks/components/KycBlock/hooks/useKycBlock/useKycBlock.tsx Reordered imports, specifically the Separator component.
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Added checkIsBusiness, TextArea, state management for comments, and updated onMutateApproveTaskById to handle comments.
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInput/useCommentInput.ts Introduced new custom hook useCommentInput for managing comment input state.
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInputLogic/useCommentInputLogic.ts Introduced new custom hook useCommentInputLogic for managing comment input logic.
    apps/backoffice-v2/CHANGELOG.md, apps/backoffice-v2/package.json Updated dependencies: @ballerine/common, @ballerine/workflow-browser-sdk, and @ballerine/workflow-node-sdk.
    apps/kyb-app/CHANGELOG.md, apps/kyb-app/package.json Updated dependencies: @ballerine/common and @ballerine/workflow-browser-sdk.
    services/workflows-service/src/workflow/dtos/document-decision-update-input.ts Added comment property to DocumentDecisionUpdateInput class and reordered imports.
    services/workflows-service/src/workflow/workflow.controller.internal.ts Added comment field in workflow decision object.
    services/workflows-service/src/workflow/workflow.service.ts Added comment field to the decision object in service methods.
    services/workflows-service/CHANGELOG.md, services/workflows-service/package.json Updated dependencies: @ballerine/common, @ballerine/workflow-core, and @ballerine/workflow-node-sdk.

    In code's vast realm, a comment's grace,
    Enhances tasks, leaves a trace.
    With updates fresh, dependencies align,
    Each function and hook, now refined.
    A rabbit's joy in changes made,
    In code's dance, improvements laid. 🐇✨

    Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

    Share
    Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>.
      • Generate unit testing code for this file.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai generate unit testing code for this file.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai generate interesting stats about this repository and render them as a table.
      • @coderabbitai show all the console.log statements in this repository.
      • @coderabbitai read src/utils.ts and generate unit testing code.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (invoked as PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to full the review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai help to get help.

    Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

    CodeRabbit Configration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @github-actions github-actions bot added enhancement New feature or request bug_fix labels May 14, 2024
    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Description updated to latest commit (484388c)

    1 similar comment
    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Description updated to latest commit (484388c)

    @github-actions GitHub Actions
    Copy link
    Contributor

    github-actions bot commented May 14, 2024 •
    edited
    Loading

    PR Review 🔍

    (Review updated until commit 484388c)

    ⏱️ Estimated effort to review [1-5]

    3, because the PR involves multiple files and layers of the application, including front-end components and back-end services. The changes are spread across both UI and API, requiring a thorough understanding of the overall system architecture and data flow. Additionally, the introduction of new functionality (comments on workflow decisions) necessitates careful consideration of both functionality and potential side effects.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Possible Bug: The comment field is optional in the mutation function, but there is no null handling before it's used. This could potentially lead to issues if comment is null when constructing the request body in updateWorkflowDecision.

    🔒 Security concerns

    No
    Code feedback:
    relevant fileapps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx
    suggestion      

    Consider initializing the comment parameter with a default value to ensure it never passes as undefined to the updateWorkflowDecision function, which might not handle undefined properly. [important]
    relevant linecomment,
    relevant fileservices/workflows-service/src/workflow/workflow.service.ts
    suggestion      

    Add validation or default handling for the comment field in the WorkflowService when constructing the decision object to prevent issues with undefined values. [important]
    relevant linecomment?: string;
    relevant fileapps/backoffice-v2/src/domains/workflows/fetchers.ts
    suggestion      

    Ensure that the comment field is properly sanitized or validated to prevent injection attacks or processing of malicious content, especially since it is user-generated input. [important]
    relevant linecomment?: string;
    relevant fileapps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx
    suggestion      

    Implement a debouncing mechanism for the setCommentValue function to optimize performance and reduce the number of state updates during rapid user input. [medium]
    relevant lineonChange={event => setCommentValue(event.target.value)}

    @github-actions GitHub Actions
    Copy link
    Contributor

    Persistent review updated to latest commit 484388c

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Security
    Sanitize the comment parameter to enhance security

    Ensure that the comment parameter is properly sanitized or validated before being used to
    prevent potential security risks such as XSS or injection attacks.

    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx [29]

    -comment,
+sanitize(comment),
    Suggestion importance[1-10]: 8

    Why: Sanitizing input is crucial for security, especially to prevent XSS and injection attacks. This suggestion addresses a significant security concern.

    		8
    Maintainability
    Refactor the large anonymous function into a named function

    To improve the readability and maintainability of the mutation function, consider
    refactoring the large anonymous function into a named function defined outside of the
    component.

    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx [15-32]

    -mutationFn: ({
+mutationFn: approveTaskMutationFunction,
    Suggestion importance[1-10]: 7

    Why: Refactoring a large anonymous function into a named function improves readability and maintainability, making the code easier to manage and understand.

    		7
    Use destructuring for imports from the same module

    Use destructuring to simplify the import statements for multiple functions from the same
    module to improve code readability.

    apps/backoffice-v2/src/domains/workflows/fetchers.ts [3-4]

    -import { env } from '@/common/env/env';
-import { getOriginUrl } from '@/common/utils/get-origin-url/get-url-origin';
+import { env, getOriginUrl } from '@/common/env';
    Suggestion importance[1-10]: 5

    Why: Using destructuring for imports improves readability but the impact on maintainability is moderate. It's a good practice but not critical.

    		5
    Enhancement
    Initialize the comment parameter with a default value

    Consider initializing the comment parameter with a default value to ensure it always has a
    predictable value when not provided explicitly.

    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx [22]

    -comment?: string;
+comment: string = '';
    Suggestion importance[1-10]: 6

    Why: Initializing the comment parameter with a default value is a good practice for clarity and avoiding undefined values, but it's not critical.

    		6

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible bug
    Handle potential undefined values for workflowId

    Consider handling potential undefined values for workflowId in the updateWorkflowDecision
    call to prevent runtime errors.

    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx [24-32]

     updateWorkflowDecision({
-  workflowId,
+  workflowId: workflowId ?? 'defaultWorkflowId', // Provide a default or handle undefined case
   documentId,
   body: {
     decision: Action.APPROVE,
     comment,
   },
   contextUpdateMethod,
 }),
    Suggestion importance[1-10]: 7

    Why: The suggestion correctly identifies a potential issue with workflowId being undefined, which could lead to runtime errors. The improvement suggestion to provide a default value or handle the undefined case is practical and enhances the robustness of the code.

    		7
    Maintainability
    Use a switch statement for decision status checks for better clarity

    Refactor the decision status checks to use a switch statement for clarity and
    maintainability.

    services/workflows-service/src/workflow/workflow.service.ts [811-831]

    -if (status === 'approved') {
-  return {
-    revisionReason: null,
-    rejectionReason: null,
-    comment: decision.comment,
-  };
-}
-if (status === 'rejected') {
-  return {
-    revisionReason: null,
-    rejectionReason: decision?.reason,
-    comment: decision.comment,
-  };
-}
-if (['revision', 'revised'].includes(status)) {
-  return {
-    revisionReason: decision?.reason,
-    rejectionReason: null,
-    comment: decision.comment,
-  };
+switch (status) {
+  case 'approved':
+    return {
+      revisionReason: null,
+      rejectionReason: null,
+      comment: decision.comment,
+    };
+  case 'rejected':
+    return {
+      revisionReason: null,
+      rejectionReason: decision?.reason,
+      comment: decision.comment,
+    };
+  case 'revision':
+  case 'revised':
+    return {
+      revisionReason: decision?.reason,
+      rejectionReason: null,
+      comment: decision.comment,
+    };
+  default:
+    return {};
 }
    Suggestion importance[1-10]: 7

    Why: The suggestion to refactor the decision status checks into a switch statement is a good practice for improving code clarity and maintainability. This change makes the code easier to read and manage, especially as the list of statuses grows or changes.

    		7
    Enhancement
    Simplify the mutation function call in the callback

    Refactor the onMutateApproveTaskById callback to directly call mutateApproveTaskById
    without wrapping it in an additional function to simplify the code and potentially improve
    performance.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx [96-99]

    -() => {
-  mutateApproveTaskById({ documentId: taskId, contextUpdateMethod, comment });
-  setCommentValue('');
-},
+mutateApproveTaskById({ documentId: taskId, contextUpdateMethod, comment });
+setCommentValue('');
    Suggestion importance[1-10]: 6

    Why: The suggestion to simplify the callback function by removing the unnecessary function wrapper around mutateApproveTaskById is correct and would make the code cleaner and potentially improve performance. However, the original code does use a function to encapsulate operations which might be intentional for scoping or other reasons.

    		6
    Performance
    Remove unused imports to optimize bundle size

    Ensure that the qs and deepCamelKeys imports are used within the file to avoid unnecessary
    imports which can lead to increased bundle size.

    apps/backoffice-v2/src/domains/workflows/fetchers.ts [10-11]

    -import qs from 'qs';
-import { deepCamelKeys } from 'string-ts';
+// Ensure these imports are used or remove them if not necessary
    Suggestion importance[1-10]: 5

    Why: The suggestion is valid as it addresses the potential issue of increased bundle size due to unused imports. However, the suggestion does not provide evidence that these imports are indeed unused within the file, which makes it less certain.

    		5

    coderabbitai[bot]
    coderabbitai bot reviewed May 14, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 1

    Out of diff range and nitpick comments (3)
    services/workflows-service/src/workflow/dtos/document-decision-update-input.ts (1)

    22-24: Ensure the comment field is properly documented in the API documentation.

    Consider adding a description for the comment field in the @ApiProperty decorator to improve API documentation clarity.

    packages/common/src/schemas/documents/default-context-schema.ts (1)

    60-60: Ensure the comment field is properly documented in the schema.

    Consider adding a description for the comment field in the schema to improve clarity and documentation.

    apps/backoffice-v2/src/lib/blocks/components/KycBlock/hooks/useKycBlock/useKycBlock.tsx (1)

    4-4: Reordering imports for better readability.

    The reordering of the Separator import improves readability but does not affect functionality.

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between f645eb0 and 484388c.
    Files selected for processing (8)
    • apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx (2 hunks)
    • apps/backoffice-v2/src/domains/workflows/fetchers.ts (2 hunks)
    • apps/backoffice-v2/src/lib/blocks/components/KycBlock/hooks/useKycBlock/useKycBlock.tsx (2 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (3 hunks)
    • packages/common/src/schemas/documents/default-context-schema.ts (1 hunks)
    • services/workflows-service/src/workflow/dtos/document-decision-update-input.ts (2 hunks)
    • services/workflows-service/src/workflow/workflow.controller.internal.ts (3 hunks)
    • services/workflows-service/src/workflow/workflow.service.ts (2 hunks)
    Additional comments not posted (6)
    apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx (1)

    18-22: Ensure the comment parameter is handled correctly in the mutationFn.

    Verify that the comment parameter is correctly passed and utilized in the updateWorkflowDecision function.

    Verification successful

    The updateWorkflowDecision function correctly handles the comment parameter within the body object. The comment parameter is optional and is passed as part of the body object to the API client.

    • The comment parameter is correctly defined and handled in the updateWorkflowDecision function.
    Scripts Executed

    The following scripts were executed for the analysis:

    Script:

    #!/bin/bash
# Description: Verify the usage of the `comment` parameter in the `updateWorkflowDecision` function.

# Test: Search for the `updateWorkflowDecision` function definition and its usage. Expect: Correct handling of the `comment` parameter.
rg --type ts 'updateWorkflowDecision'

    Length of output: 1553

    Script:

    #!/bin/bash
# Description: Extract the definition of the `updateWorkflowDecision` function to verify the handling of the `comment` parameter.

# Test: Extract the function definition from `fetchers.ts`.
ast-grep --lang typescript --pattern 'export const updateWorkflowDecision = async ({ $$$ }) => { $$$ }' apps/backoffice-v2/src/domains/workflows/fetchers.ts

    Length of output: 2335

    apps/backoffice-v2/src/domains/workflows/fetchers.ts (1)

    242-242: Ensure the comment field is handled correctly in the updateWorkflowDecision function.

    Verify that the comment field is correctly passed and utilized in the updateWorkflowDecision function.

    services/workflows-service/src/workflow/workflow.controller.internal.ts (1)

    273-273: Ensure the comment field is handled correctly in the updateDocumentDecisionById method.

    Verify that the comment field is correctly passed and utilized in the updateDocumentDecisionById method.

    Verification successful

    The comment field is correctly handled within the updateDocumentDecisionById method. It is assigned to the newDecision object and used appropriately based on the decision status.

    • The comment field is included in the newDecision object for all decision statuses (approved, rejected, revision, revised).
    Scripts Executed

    The following scripts were executed for the analysis:

    Script:

    #!/bin/bash
# Description: Verify the usage of the `comment` field in the `updateDocumentDecisionById` method.

# Test: Search for the `updateDocumentDecisionById` method definition and its usage. Expect: Correct handling of the `comment` field.
rg --type ts 'updateDocumentDecisionById'

    Length of output: 593

    Script:

    #!/bin/bash
# Description: Inspect the `updateDocumentDecisionById` method definition in `workflow.service.ts` to verify the handling of the `comment` field.

# Test: Extract the `updateDocumentDecisionById` method definition.
ast-grep --lang typescript --pattern $'async updateDocumentDecisionById($_) { $$$ }' services/workflows-service/src/workflow/workflow.service.ts

    Length of output: 612

    Script:

    #!/bin/bash
# Description: Inspect the `updateDocumentDecisionById` method definition in `workflow.service.ts` to verify the handling of the `comment` field.

# Test: Extract the `updateDocumentDecisionById` method definition.
ast-grep --lang typescript --pattern 'async updateDocumentDecisionById($$) { $$ }' services/workflows-service/src/workflow/workflow.service.ts

    Length of output: 610

    Script:

    #!/bin/bash
# Description: Search for the `updateDocumentDecisionById` method definition and its content in `workflow.service.ts` to verify the handling of the `comment` field.

# Test: Extract the `updateDocumentDecisionById` method definition and its content.
rg --context 10 'async updateDocumentDecisionById' services/workflows-service/src/workflow/workflow.service.ts

    Length of output: 545

    Script:

    #!/bin/bash
# Description: Search for the complete `updateDocumentDecisionById` method definition in `workflow.service.ts` to verify the handling of the `comment` field.

# Test: Extract the complete `updateDocumentDecisionById` method definition.
rg --context 30 'async updateDocumentDecisionById' services/workflows-service/src/workflow/workflow.service.ts

    Length of output: 1541

    Script:

    #!/bin/bash
# Description: Verify the usage of the `comment` field within the `updateDocumentDecisionById` method in `workflow.service.ts`.

# Test: Search for the usage of the `comment` field within the method body.
rg --context 30 'comment' services/workflows-service/src/workflow/workflow.service.ts

    Length of output: 5331

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (1)

    274-295: Ensure the comment input is properly handled in the approval dialog.

    Verify that the comment input is correctly passed and utilized in the approval dialog.

    services/workflows-service/src/workflow/workflow.service.ts (2)

    783-783: Addition of comment field in the decision parameter is consistent with the PR objectives.

    814-814: Inclusion of comment field in the newDecision object is consistent with the PR objectives and logically extends the previous change.

    Also applies to: 822-822, 830-830

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Outdated Show resolved Hide resolved
    coderabbitai[bot]
    coderabbitai bot reviewed May 14, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 8

    Out of diff range and nitpick comments (34)
    packages/workflow-core/CHANGELOG.md (12)

    Line range hint 64-64: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [9fe7a5c10]
+ - Updated dependencies [9fe7a5c10]

    Line range hint 283-283: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [59afd0b4]
+ - Updated dependencies [59afd0b4]

    Line range hint 385-385: Hyphenate "Pre release" to "Pre-release".

    - - 801fc639: Pre release
+ - 801fc639: Pre-release

    Line range hint 397-397: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [801fc639]
+ - Updated dependencies [801fc639]

    Line range hint 425-425: Hyphenate "Version bump pre" to "Version bump-pre".

    - - b1cebf50: Version bump pre
+ - b1cebf50: Version bump-pre

    Line range hint 437-437: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [b1cebf50]
+ - Updated dependencies [b1cebf50]

    Line range hint 450-450: Hyphenate "Version bump pre" to "Version bump-pre".

    - - Version bump pre
+ - Version bump-pre

    Line range hint 490-490: Hyphenate "bump pre" to "bump-pre".

    - - bump pre
+ - bump-pre

    Line range hint 506-506: Hyphenate "Pre release" to "Pre-release".

    - - Pre release
+ - Pre-release

    Line range hint 514-514: Hyphenate "pre" to "pre-".

    - - pre
+ - pre-

    Line range hint 522-522: Hyphenate "pre" to "pre-".

    - - pre
+ - pre-

    Line range hint 791-791: Replace "infra" with "infrastructure" for clarity.

    - - fixed monorepo infra
+ - fixed monorepo infrastructure
    examples/headless-example/CHANGELOG.md (11)

    Line range hint 75-75: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [9fe7a5c10]
+ - Updated dependencies [9fe7a5c10]

    Line range hint 319-319: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [59afd0b4]
+ - Updated dependencies [59afd0b4]

    Line range hint 421-421: Hyphenate "Pre release" to "Pre-release".

    - - 801fc639: Pre release
+ - 801fc639: Pre-release

    Line range hint 434-434: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [801fc639]
+ - Updated dependencies [801fc639]

    Line range hint 465-465: Hyphenate "Version bump pre" to "Version bump-pre".

    - - b1cebf50: Version bump pre
+ - b1cebf50: Version bump-pre

    Line range hint 478-478: Remove duplicate "Updated dependencies" phrase.

    - - Updated dependencies
- - Updated dependencies [b1cebf50]
+ - Updated dependencies [b1cebf50]

    Line range hint 492-492: Hyphenate "Version bump pre" to "Version bump-pre".

    - - Version bump pre
+ - Version bump-pre

    Line range hint 537-537: Hyphenate "bump pre" to "bump-pre".

    - - bump pre
+ - bump-pre

    Line range hint 555-555: Hyphenate "Pre release" to "Pre-release".

    - - Pre release
+ - Pre-release

    Line range hint 564-564: Hyphenate "pre" to "pre-".

    - - pre
+ - pre-

    Line range hint 573-573: Hyphenate "pre" to "pre-".

    - - pre
+ - pre-
    sdks/workflow-browser-sdk/CHANGELOG.md (11)

    Line range hint 73-73: Remove duplicated phrase "Updated dependencies".

    The phrase "Updated dependencies" is duplicated. It should be used only once.

    Line range hint 444-444: Remove duplicated phrase "Updated dependencies".

    The phrase "Updated dependencies" is duplicated. It should be used only once.

    Line range hint 488-488: Remove duplicated phrase "Updated dependencies".

    The phrase "Updated dependencies" is duplicated. It should be used only once.

    Line range hint 863-863: Remove duplicated phrase "Updated dependencies".

    The phrase "Updated dependencies" is duplicated. It should be used only once.

    Line range hint 431-431: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "Pre bump" should be "Pre-bump".

    Line range hint 475-475: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "Version bump pre" should be "Version bump-pre".

    Line range hint 502-502: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "Version bump pre" should be "Version bump-pre".

    Line range hint 547-547: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "bump pre" should be "bump-pre".

    Line range hint 565-565: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "Pre release" should be "Pre-release".

    Line range hint 574-574: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "pre" should be "pre-".

    Line range hint 583-583: Hyphenate prefixes followed by proper nouns or dates.

    Prefixes followed by proper nouns or dates should be hyphenated. For example, "pre" should be "pre-".

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between 484388c and 8eb41e3.
    Files ignored due to path filters (1)
    • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
    Files selected for processing (20)
    • apps/backoffice-v2/CHANGELOG.md (1 hunks)
    • apps/backoffice-v2/package.json (2 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (3 hunks)
    • apps/kyb-app/CHANGELOG.md (1 hunks)
    • apps/kyb-app/package.json (2 hunks)
    • examples/headless-example/CHANGELOG.md (1 hunks)
    • examples/headless-example/package.json (2 hunks)
    • packages/common/CHANGELOG.md (1 hunks)
    • packages/common/package.json (1 hunks)
    • packages/workflow-core/CHANGELOG.md (1 hunks)
    • packages/workflow-core/package.json (2 hunks)
    • sdks/web-ui-sdk/CHANGELOG.md (1 hunks)
    • sdks/web-ui-sdk/package.json (2 hunks)
    • sdks/workflow-browser-sdk/CHANGELOG.md (1 hunks)
    • sdks/workflow-browser-sdk/package.json (2 hunks)
    • sdks/workflow-node-sdk/CHANGELOG.md (1 hunks)
    • sdks/workflow-node-sdk/package.json (2 hunks)
    • services/workflows-service/CHANGELOG.md (1 hunks)
    • services/workflows-service/package.json (2 hunks)
    • websites/docs/package.json (1 hunks)
    Files skipped from review due to trivial changes (8)
    • apps/backoffice-v2/package.json
    • apps/kyb-app/package.json
    • examples/headless-example/package.json
    • packages/common/package.json
    • packages/workflow-core/package.json
    • sdks/workflow-browser-sdk/package.json
    • sdks/workflow-node-sdk/package.json
    • services/workflows-service/package.json
    Files skipped from review as they are similar to previous changes (1)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx
    Additional Context Used
    LanguageTool (97)
    apps/backoffice-v2/CHANGELOG.md (12)

    Near line 87: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 402: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.5.29 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...

    Near line 556: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 575: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 626: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 640: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 660: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 722: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 758: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 783: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    Near line 794: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    Near line 987: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...> demo ## 0.4.11 ### Patch Changes - Updated dependencies - Updated dependencies [cce4a66] - @ballerine/[email protected] -...

    apps/kyb-app/CHANGELOG.md (12)

    Near line 84: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 380: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.1.23 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...

    Near line 521: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 540: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 587: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 601: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 620: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 677: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...5-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 711: This expression is normally spelled as one or with a hyphen.
    Context: ... 0.1.5-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 735: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    Near line 745: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    Near line 886: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...ed DynamicForm & TextArea & css fixes - Updated dependencies - Updated dependencies [c06f234] - @ballerine/[email protected] ## ...

    examples/headless-example/CHANGELOG.md (11)

    Near line 75: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 319: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.1.26 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...

    Near line 421: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 434: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 465: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 478: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 492: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 537: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...

    Near line 555: This expression is normally spelled as one or with a hyphen.
    Context: ...0.1.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 564: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.1.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    Near line 573: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.1.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...

    packages/common/CHANGELOG.md (3)

    Near line 280: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 304: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 359: This expression is normally spelled as one or with a hyphen.
    Context: ...0.7.13-3e08f108.2 ### Patch Changes - Pre release ## 0.7.13-3e08f108.1 ### Patch Change...

    packages/workflow-core/CHANGELOG.md (12)

    Near line 64: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 283: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.7.28 ## 0.5.26 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...

    Near line 385: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 397: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 425: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 437: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 450: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/[email protected]....

    Near line 490: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/[email protected]....

    Near line 506: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/c...

    Near line 514: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....

    Near line 522: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....

    Near line 791: To make your text as clear as possible to all readers, do not use this foreign term. Possible alternatives are “below” or “further on” (in a document).
    Context: ...dded missing changeset - fixed monorepo infra ## 0.4.5 ### Patch Changes - build -...

    sdks/web-ui-sdk/CHANGELOG.md (11)

    Near line 52: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 243: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.7.28 ## 1.4.24 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...

    Near line 333: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 345: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 372: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 384: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 397: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...08.9 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/[email protected]....

    Near line 437: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0-3e08f108.4 ### Patch Changes - bump pre - Updated dependencies - @ballerine/[email protected]....

    Near line 453: This expression is normally spelled as one or with a hyphen.
    Context: ...1.4.10-3e08f108.2 ### Patch Changes - Pre release - Updated dependencies - @ballerine/c...

    Near line 461: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1.4.10-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....

    Near line 469: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1.4.10-3e08f108.0 ### Patch Changes - pre - Updated dependencies - @ballerine/[email protected]....

    sdks/workflow-browser-sdk/CHANGELOG.md (13)

    Near line 54: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: [email protected] ## 0.6.3 ### Patch Changes - Updated dependencies - Updated dependencies [0244d3e] - @ballerine/workflow-cor...

    Near line 73: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 431: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 444: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 475: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 488: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 502: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 547: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 565: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 574: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    Near line 583: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    Near line 863: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: [email protected] ## 0.4.4 ### Patch Changes - Updated dependencies - Updated dependencies [be5c9bc] - @ballerine/[email protected] ...

    Near line 897: To make your text as clear as possible to all readers, do not use this foreign term. Possible alternatives are “below” or “further on” (in a document).
    Context: ...dded missing changeset - fixed monorepo infra - Updated dependencies [700d492] - @b...

    sdks/workflow-node-sdk/CHANGELOG.md (11)

    Near line 44: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: [email protected] ## 0.6.3 ### Patch Changes - Updated dependencies - Updated dependencies [0244d3e] - @ballerine/workflow-cor...

    Near line 62: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...Changes - ver bump - 9fe7a5c: bump - Updated dependencies - Updated dependencies [9fe7a5c] - @ballerine/workflow-cor...

    Near line 360: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 373: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 400: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 413: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 426: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 466: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 482: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 490: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    Near line 498: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    services/workflows-service/CHANGELOG.md (12)

    Near line 62: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: [email protected] ## 0.7.2 ### Patch Changes - Updated dependencies - Updated dependencies [0244d3e] - @ballerine/workflow-cor...

    Near line 89: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...

    Near line 494: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...

    Near line 507: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...

    Near line 541: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...

    Near line 554: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...

    Near line 569: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.10 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 619: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.5 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-co...

    Near line 639: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.3 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...

    Near line 649: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    Near line 659: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-co...

    Near line 978: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: [email protected] ## 0.4.11 ### Patch Changes - Updated dependencies - Updated dependencies [be5c9bc] - @ballerine/[email protected] ...

    Additional comments not posted (3)
    websites/docs/package.json (1)

    20-20: Dependency addition looks good.

    sdks/web-ui-sdk/package.json (1)

    99-99: Dependency addition looks good.

    apps/backoffice-v2/CHANGELOG.md (1)

    3-10: Changelog entry for version 0.7.8 looks good.

    services/workflows-service/CHANGELOG.md Show resolved Hide resolved
    services/workflows-service/CHANGELOG.md Show resolved Hide resolved
    apps/kyb-app/CHANGELOG.md Outdated Show resolved Hide resolved
    sdks/workflow-browser-sdk/CHANGELOG.md Show resolved Hide resolved
    sdks/workflow-browser-sdk/CHANGELOG.md Show resolved Hide resolved
    packages/common/CHANGELOG.md Show resolved Hide resolved
    sdks/workflow-node-sdk/CHANGELOG.md Show resolved Hide resolved
    sdks/web-ui-sdk/CHANGELOG.md Show resolved Hide resolved
    coderabbitai[bot]
    coderabbitai bot reviewed May 26, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 2

    Outside diff range and nitpick comments (6)
    apps/backoffice-v2/CHANGELOG.md (1)

    Line range hint 980-980: Ensure headings are properly formatted with surrounding blank lines.

    - ## 0.4.12
+ 
+ ## 0.4.12
+
    services/workflows-service/src/workflow/workflow.service.ts (5)

    Line range hint 855-855: Avoid using any type. Specify explicit types to improve type safety and maintainability.

    Also applies to: 876-876, 1047-1047, 1081-1081, 1096-1096, 1101-1101, 1105-1105, 1106-1106, 1141-1141

    Line range hint 899-899: Avoid using non-null assertions. Consider handling potential null values gracefully.

    Also applies to: 968-968, 1384-1384

    Line range hint 1085-1091: Prefer using for...of loops over forEach for better performance and readability.

    - array.forEach(element => {
+ for (const element of array) {

    Also applies to: 1166-1177

    Line range hint 1175-1175: Avoid using non-null assertions. Check for null or undefined before accessing properties.

    Line range hint 1414-1414: Declare variables separately to enhance readability and avoid potential hoisting issues.

    - let var1, var2;
+ let var1;
+ let var2;
    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between 8eb41e3 and 9ffb988.
    Files ignored due to path filters (1)
    • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
    Files selected for processing (8)
    • apps/backoffice-v2/CHANGELOG.md (1 hunks)
    • apps/backoffice-v2/package.json (1 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (4 hunks)
    • apps/kyb-app/CHANGELOG.md (1 hunks)
    • apps/kyb-app/package.json (1 hunks)
    • services/workflows-service/package.json (2 hunks)
    • services/workflows-service/src/workflow/workflow.controller.internal.ts (3 hunks)
    • services/workflows-service/src/workflow/workflow.service.ts (2 hunks)
    Files skipped from review due to trivial changes (2)
    • apps/kyb-app/package.json
    • services/workflows-service/package.json
    Additional Context Used
    LanguageTool (24)
    apps/backoffice-v2/CHANGELOG.md (12)

    Near line 88: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...
    Rule ID: PHRASE_REPETITION

    Near line 403: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.5.29 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...
    Rule ID: PHRASE_REPETITION

    Near line 557: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...
    Rule ID: PRE_PRO_ANTI

    Near line 576: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...
    Rule ID: PHRASE_REPETITION

    Near line 627: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...
    Rule ID: PRE_PRO_ANTI

    Near line 641: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...
    Rule ID: PHRASE_REPETITION

    Near line 661: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 723: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...1-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 759: This expression is normally spelled as one or with a hyphen.
    Context: ...0.5.11-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...
    Rule ID: EN_COMPOUNDS_PRE_RELEASE

    Near line 784: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 795: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...0.5.11-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 988: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...> demo ## 0.4.11 ### Patch Changes - Updated dependencies - Updated dependencies [cce4a66] - @ballerine/[email protected] -...
    Rule ID: PHRASE_REPETITION

    apps/kyb-app/CHANGELOG.md (12)

    Near line 85: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...a5c10: bump - 9fe7a5c: Version bump - Updated dependencies - Updated dependencies [9fe7a5c] - Updated dependencies [9fe...
    Rule ID: PHRASE_REPETITION

    Near line 381: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...0.5.27 ## 0.1.23 ### Patch Changes - Updated dependencies - Updated dependencies [59afd0b] - @ballerine/[email protected]...
    Rule ID: PHRASE_REPETITION

    Near line 522: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...: Pre bump - 801fc63: Bump - 801fc63: pre - Version bump - 801fc63: Pre release - 801fc63...
    Rule ID: PRE_PRO_ANTI

    Near line 541: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...39] - Updated dependencies [801fc63] - Updated dependencies - Updated dependencies [801fc63] - Updated dependencies [801f...
    Rule ID: PHRASE_REPETITION

    Near line 588: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...bf50: bump pre - b1cebf5: Version bump pre - Bump - b1cebf5: Pre bump - b1cebf5: Pre bu...
    Rule ID: PRE_PRO_ANTI

    Near line 602: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...50] - Updated dependencies [b1cebf5] - Updated dependencies - Updated dependencies [b1cebf5] - Updated dependencies [b1ce...
    Rule ID: PHRASE_REPETITION

    Near line 621: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...8.15 ### Patch Changes - Version bump pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 678: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ...5-3e08f108.9 ### Patch Changes - bump pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 712: This expression is normally spelled as one or with a hyphen.
    Context: ... 0.1.5-3e08f108.5 ### Patch Changes - Pre release - Updated dependencies - @ballerine/w...
    Rule ID: EN_COMPOUNDS_PRE_RELEASE

    Near line 736: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.2 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 746: Prefixes followed by proper nouns or dates are typically hyphenated.
    Context: ... 0.1.5-3e08f108.1 ### Patch Changes - pre - Updated dependencies - @ballerine/workflow-br...
    Rule ID: PRE_PRO_ANTI

    Near line 887: This phrase is duplicated. You should probably use “Updated dependencies” only once.
    Context: ...ed DynamicForm & TextArea & css fixes - Updated dependencies - Updated dependencies [c06f234] - @ballerine/[email protected] ## ...
    Rule ID: PHRASE_REPETITION

    Markdownlint (4)
    apps/backoffice-v2/CHANGELOG.md (4)

    980: Expected: 1; Actual: 0; Above
    Headings should be surrounded by blank lines

    980: Expected: 1; Actual: 0; Below
    Headings should be surrounded by blank lines

    980: null
    Headings must start at the beginning of the line

    980: null
    Multiple top-level headings in the same document

    Biome (48)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (8)

    271-271: Do not use template literals if interpolation and special-character handling are not needed.

    272-272: Do not use template literals if interpolation and special-character handling are not needed.

    281-281: Do not use template literals if interpolation and special-character handling are not needed.

    284-284: Do not use template literals if interpolation and special-character handling are not needed.

    306-306: Do not use template literals if interpolation and special-character handling are not needed.

    8-9: All these imports are only used as types.

    16-17: All these imports are only used as types.

    29-30: Some named imports are only used as types.

    services/workflows-service/src/workflow/workflow.controller.internal.ts (20)

    59-59: Decorators are not valid here.

    67-67: Decorators are not valid here.

    68-68: Decorators are not valid here.

    80-80: Decorators are not valid here.

    81-81: Decorators are not valid here.

    110-110: Decorators are not valid here.

    111-111: Decorators are not valid here.

    112-112: Decorators are not valid here.

    123-123: Decorators are not valid here.

    140-140: Decorators are not valid here.

    141-141: Decorators are not valid here.

    142-142: Decorators are not valid here.

    143-143: Decorators are not valid here.

    162-162: Decorators are not valid here.

    163-163: Decorators are not valid here.

    164-164: Decorators are not valid here.

    189-189: Decorators are not valid here.

    190-190: Decorators are not valid here.

    191-191: Decorators are not valid here.

    210-210: Decorators are not valid here.

    services/workflows-service/src/workflow/workflow.service.ts (20)

    272-272: This variable implicitly has the any type.

    855-855: Unexpected any. Specify a different type.

    876-876: Unexpected any. Specify a different type.

    899-899: Forbidden non-null assertion.

    899-899: Forbidden non-null assertion.

    968-968: Forbidden non-null assertion.

    1047-1047: Unexpected any. Specify a different type.

    1081-1081: Unexpected any. Specify a different type.

    1085-1091: Prefer for...of instead of forEach.

    1087-1089: Prefer for...of instead of forEach.

    1096-1096: Unexpected any. Specify a different type.

    1101-1101: Unexpected any. Specify a different type.

    1105-1105: Unexpected any. Specify a different type.

    1106-1106: Unexpected any. Specify a different type.

    1141-1141: This variable implicitly has the any type.

    1166-1177: Prefer for...of instead of forEach.

    1175-1175: Forbidden non-null assertion.

    1384-1384: Forbidden non-null assertion.

    1384-1384: Forbidden non-null assertion.

    1414-1414: Declare variables separately

    Additional comments not posted (7)
    apps/backoffice-v2/package.json (1)

    53-57: Updated dependencies to newer versions.

    This update aligns with the PR's objective to use the latest versions of dependencies which likely bring improvements and bug fixes.

    services/workflows-service/src/workflow/workflow.controller.internal.ts (1)

    270-270: Added handling for the comment field in the updateDocumentDecisionById method.

    This change supports the new feature of adding comments to workflow decisions, aligning with the PR's objectives.

    apps/kyb-app/CHANGELOG.md (1)

    8-9: Updated dependencies listed in the changelog.

    The changelog correctly reflects the updates made in the dependencies, ensuring accurate documentation.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (2)

    84-98: The implementation of the comment functionality in onMutateApproveTaskById looks correct and aligns with the PR objectives.

    Line range hint 8-9: Ensure that imports used only as types are imported with type to clarify their usage and potentially optimize bundling.
    [REFACTOR_SUGGESTion]

    - import { TWorkflowById } from '@/domains/workflows/fetchers';
+ import type { TWorkflowById } from '@/domains/workflows/fetchers';
- import { FunctionComponent, useCallback, useMemo, useState } from 'react';
+ import type { FunctionComponent } from 'react';
+ import { useCallback, useMemo, useState } from 'react';

    Also applies to: 16-17, 29-30

    apps/backoffice-v2/CHANGELOG.md (1)

    8-10: Dependency versions updated to match the latest SDKs and common libraries as per PR objectives.

    services/workflows-service/src/workflow/workflow.service.ts (1)

    800-800: Consider specifying a type for comment in the decision object.

    Verification successful

    The search results indicate that the comment property is consistently defined as a string in various parts of the codebase. Specifically, it appears in multiple files with the type string or string?, confirming that the type for comment is indeed specified.

    • services/workflows-service/src/workflow/workflow.service.ts: comment?: string;
    • services/workflows-service/src/workflow/dtos/document-decision-update-input.ts: comment?: string;
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx: comment?: string;
    • apps/backoffice-v2/src/domains/workflows/fetchers.ts: comment?: string;
    • apps/backoffice-v2/src/domains/entities/hooks/mutations/useApproveTaskByIdMutation/useApproveTaskByIdMutation.tsx: comment?: string;

    Given this evidence, the type for comment is already specified as string in the codebase.

    Scripts Executed

    The following scripts were executed for the analysis:

    Script:

    #!/bin/bash
# Description: Verify if the type for `comment` is defined elsewhere in the codebase.

# Test: Search for the `comment` type definition. Expect: Type definition for `comment`.
ast-grep --lang typescript --pattern $'type Comment = $_;'

    Length of output: 59

    Script:

    #!/bin/bash
# Description: Verify if the type for `comment` is defined or used elsewhere in the codebase.

# Test 1: Search for `comment` in type aliases or interfaces.
ast-grep --lang typescript --pattern $'type $_ = { comment: $_ };'
ast-grep --lang typescript --pattern $'interface $_ { comment: $_; }'

# Test 2: Search for `comment` usage in the codebase to infer its type.
rg 'comment' --type ts

    Length of output: 8319

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Show resolved Hide resolved
    services/workflows-service/src/workflow/workflow.service.ts Show resolved Hide resolved
    coderabbitai[bot]
    coderabbitai bot reviewed May 26, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 3

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between 9ffb988 and e26db1d.
    Files selected for processing (2)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInput/useCommentInput.ts (1 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (5 hunks)
    Files skipped from review due to trivial changes (1)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInput/useCommentInput.ts
    Additional Context Used
    Biome (8)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (8)

    276-276: Do not use template literals if interpolation and special-character handling are not needed.

    277-277: Do not use template literals if interpolation and special-character handling are not needed.

    286-286: Do not use template literals if interpolation and special-character handling are not needed.

    287-287: Do not use template literals if interpolation and special-character handling are not needed.

    307-307: Do not use template literals if interpolation and special-character handling are not needed.

    8-9: All these imports are only used as types.

    17-18: All these imports are only used as types.

    30-31: Some named imports are only used as types.

    Additional comments not posted (3)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (3)

    12-12: The addition of useCommentInput is a good integration for handling the new comment functionality.

    28-28: The addition of TextArea from @ballerine/ui is appropriate for the new comment functionality.

    295-295: The use of || undefined is clever to ensure that undefined is passed instead of an empty string, which might be significant depending on how the backend handles these values. However, consider if this could be handled more gracefully within the mutateApproveTaskById function itself.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Show resolved Hide resolved
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Outdated Show resolved Hide resolved
    coderabbitai[bot]
    coderabbitai bot reviewed May 26, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 2

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between e26db1d and e06b96b.
    Files selected for processing (3)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInput/useCommentInput.ts (1 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (5 hunks)
    • services/workflows-service/src/workflow/dtos/document-decision-update-input.ts (2 hunks)
    Files skipped from review as they are similar to previous changes (1)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInput/useCommentInput.ts
    Additional Context Used
    Biome (8)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (8)

    276-276: Do not use template literals if interpolation and special-character handling are not needed.

    277-277: Do not use template literals if interpolation and special-character handling are not needed.

    286-286: Do not use template literals if interpolation and special-character handling are not needed.

    287-287: Do not use template literals if interpolation and special-character handling are not needed.

    307-307: Do not use template literals if interpolation and special-character handling are not needed.

    8-9: All these imports are only used as types.

    17-18: All these imports are only used as types.

    30-31: Some named imports are only used as types.

    Additional comments not posted (3)
    services/workflows-service/src/workflow/dtos/document-decision-update-input.ts (1)

    22-28: The addition of the comment field with appropriate decorators is well-implemented.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (2)

    12-12: The addition of useCommentInput import is appropriate for managing comment state.

    28-28: The import of TextArea from @ballerine/ui is correctly placed to support the new comment functionality.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Outdated Show resolved Hide resolved
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Outdated Show resolved Hide resolved
    @chesterkmr chesterkmr requested a review from Omri-Levy May 26, 2024 12:20
    @chesterkmr chesterkmr changed the title BAL-1957(Do not merge yet, TBD migration) BAL-1957 May 26, 2024
    coderabbitai[bot]
    coderabbitai bot reviewed May 27, 2024
    View reviewed changes
    Copy link
    Contributor

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 1

    Review Details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits Files that changed from the base of the PR and between e06b96b and b498840.
    Files selected for processing (2)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInputLogic/useCommentInputLogic.ts (1 hunks)
    • apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (5 hunks)
    Additional Context Used
    Biome (8)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (8)

    272-272: Do not use template literals if interpolation and special-character handling are not needed.

    273-273: Do not use template literals if interpolation and special-character handling are not needed.

    282-282: Do not use template literals if interpolation and special-character handling are not needed.

    283-283: Do not use template literals if interpolation and special-character handling are not needed.

    303-303: Do not use template literals if interpolation and special-character handling are not needed.

    8-9: All these imports are only used as types.

    17-18: All these imports are only used as types.

    30-31: Some named imports are only used as types.

    Additional comments not posted (3)
    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/hooks/useCommentInputLogic/useCommentInputLogic.ts (1)

    3-19: Well-implemented custom hook for managing comment input.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx (2)

    85-100: Ensure proper handling of the comment parameter in the approval process.

    12-12: Correctly integrated the useCommentInputLogic hook.

    apps/backoffice-v2/src/lib/blocks/hooks/useDocumentBlocks/useDocumentBlocks.tsx Show resolved Hide resolved
    @chesterkmr chesterkmr merged commit c0baf62 into dev May 27, 2024
    9 checks passed
    @chesterkmr chesterkmr deleted the bal-1957 branch May 27, 2024 07:08
    @coderabbitai coderabbitai bot mentioned this pull request Oct 8, 2024
    Merged
    @Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

    @Omri-Levy Omri-Levy Omri-Levy approved these changes

    Assignees
    No one assigned
    Labels
    bug_fix enhancement New feature or request Review effort [1-5]: 3
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @chesterkmr @Omri-Levy