bal 1969 - Add new rules

[liorzam]

Summary by CodeRabbit

• New Features

  • Enhanced alert generation capabilities with additional properties and configurations.
  • Introduced a new method for evaluating transaction averages in data analytics.

• Enhancements

  • Improved test coverage for alert functionality, including new scenarios and conditions.

• Refactor

  • Streamlined transaction evaluation functions and updated naming conventions for clarity.

• Bug Fixes

  • Adjusted alert definitions to ensure accurate transaction monitoring based on new criteria.

• Documentation

  • Updated internal documentation to reflect changes in functionality and test configurations.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4acc03c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The updates across the workflows-service module focus on refining transaction analysis and alert generation. Key changes include renaming a function for clarity, introducing new alert definitions, and enhancing test coverage for new scenarios. Additionally, the integration of new parameters and types supports more detailed transaction evaluations.

Changes

Files	Summary
.../scripts/alerts/generate-alerts.ts .../src/data-analytics/types.ts	Renamed function from evaluateTransactionLimitHistoricAverageInbound to evaluateTransactionAvg. Added new parameters and alert definitions.
.../src/alert/alert.service.intg.test.ts	Enhanced testing logic, added imports, and introduced new test cases for alerts.
.../src/data-analytics/data-analytics.service.ts	Added evaluateTransactionAvg method and related types, updated existing methods.

🐇✨
In the land of code where the data hops,
A rabbit tweaked the alerts non-stop.
"Let's make things clear," it said with a grin,
Renaming functions and testing within.
Now with each commit, the code does play,
Celebrating changes in a whimsical way! 🎉🐾

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b74a303 and 5ca5fd5.

Files selected for processing (4)

• services/workflows-service/scripts/alerts/generate-alerts.ts (4 hunks)
• services/workflows-service/src/alert/alert.service.intg.test.ts (10 hunks)
• services/workflows-service/src/data-analytics/data-analytics.service.ts (5 hunks)
• services/workflows-service/src/data-analytics/types.ts (3 hunks)

Files not reviewed due to errors (1)

• services/workflows-service/src/alert/alert.service.intg.test.ts (no review received)

Additional comments not posted (6)

services/workflows-service/src/data-analytics/types.ts (3)

99-103: The addition of TPeerGroupTransactionAverageOptions type supports enhanced transaction analysis capabilities.

---

22-35: The modifications to InlineRule introduce more granular configurations for transaction evaluations, aligning with the new functionalities.

---

3-3: The addition of the TProjectId import supports consistent referencing of project IDs in type definitions.

services/workflows-service/src/data-analytics/data-analytics.service.ts (2)

413-476: The addition of the evaluateTransactionAvg method enhances the service's capability to perform detailed transaction analysis.

---

9-9: The import of TPeerGroupTransactionAverageOptions is essential for the new evaluateTransactionAvg method to function correctly.

services/workflows-service/scripts/alerts/generate-alerts.ts (1)

Line range hint 382-467: The modifications to ALERT_DEFINITIONS enhance the alert generation capabilities by introducing more precise and condition-specific alerts.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5ca5fd5 and addbbd2.

Files selected for processing (2)

• services/workflows-service/src/alert/alert.service.intg.test.ts (10 hunks)
• services/workflows-service/src/data-analytics/types.ts (3 hunks)

Files skipped from review as they are similar to previous changes (2)

• services/workflows-service/src/alert/alert.service.intg.test.ts
• services/workflows-service/src/data-analytics/types.ts