Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karpatkey Safe App feedback #304

Open
agualis opened this issue Dec 11, 2024 · 1 comment
Open

Karpatkey Safe App feedback #304

agualis opened this issue Dec 11, 2024 · 1 comment
Assignees

Comments

@agualis
Copy link
Collaborator

agualis commented Dec 11, 2024

We were able to deposit on the gnosis side a few comments about the operation

  1. since the approvals leverage permit2 the obligatory signature basically stops any safe that uses a nested approach (we use those for operations)
  2. Since we used WC, we needed to refresh the whole page so the approvals were read, closing the modal was not enough
  3. the modal always overestimate the wstETH and sDAI values, from my tests it seems to calculate it as the underlying and then on the actual deposit you always use less
  4. because the pool is called GNO / sDAI people may expect to be able to deposit sDAI directly but when you go to add liquidity you only have wxDAI as an option
  5. talking about naming conventions, the current wrapped/aTOKEN/chain/asset looks less than ideal
  6. waGNOwstETH is not showing a price currently so TVL on the UI looks off
    because of 3 and 6 we were not able to exactly validate the deposit amounts so some ended a bit lower and others a bit higher but we can adjust over the coming days
@agualis agualis self-assigned this Dec 11, 2024
@garethfuller
Copy link
Contributor

@agualis could you convert this into actionable tickets when you get a chance, please. I'll move this to the first column which is where tickets should go if they're not well defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants