You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When running Pydeequ 1.0.1 the test generated by ConstraintSuggestionRunner include tests using the isContainedIn() function that fail during execution.
The cause is that the suggested tests include a lambda assertion which the python function does not accept as it takes 3 positional arguments but the suggested tests has 5
To Reproduce
Steps to reproduce the behavior:
Generate a test statement using a dataset that is incomplete, resulting in a suggestion for a test using isContainedIn() which uses a lambda:
Example: 'value'is empty for more then 97% of the records:
isContainedIn("value", [""], lambda x: x >= 0.97, "It should be above 0.97!")
Execute the test
Check output for error:
TypeError: isContainedIn() takes 3 positional arguments but 5 were given
It is unclear to me whether the suggested test is valid and the isContainedIn function needs to be extended or whether the change was made for a reason and thus the ConstraintSuggestionRunner should be adjusted to leave out the broken tests.
A previously made pull request does show how to revert the change: #58
The text was updated successfully, but these errors were encountered:
Describe the bug
When running Pydeequ 1.0.1 the test generated by ConstraintSuggestionRunner include tests using the isContainedIn() function that fail during execution.
The cause is that the suggested tests include a lambda assertion which the python function does not accept as it takes 3 positional arguments but the suggested tests has 5
To Reproduce
Steps to reproduce the behavior:
This issue has been reported before: #65
The cause is that the current implementation of the isContainedIn was edited in 30375bb#diff-783716851e9837b9753e643de1f15e031f79bed4ef27e07ce67eeddc5a3fb2ee but the ConstraintSuggestionRunner was not updated to match the latest implementation.
It is unclear to me whether the suggested test is valid and the isContainedIn function needs to be extended or whether the change was made for a reason and thus the ConstraintSuggestionRunner should be adjusted to leave out the broken tests.
A previously made pull request does show how to revert the change: #58
The text was updated successfully, but these errors were encountered: