Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bedrock): agent module refactoring to follow best practices from CDK #731

Open
2 tasks done
maxtybar opened this issue Oct 3, 2024 · 2 comments · May be fixed by #770
Open
2 tasks done

(bedrock): agent module refactoring to follow best practices from CDK #731

maxtybar opened this issue Oct 3, 2024 · 2 comments · May be fixed by #770
Labels
backlog enhancement New feature or request

Comments

@maxtybar
Copy link
Contributor

maxtybar commented Oct 3, 2024

Describe the feature

Working on refactoring Agent module/construct to follow CDK's best practices: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#metrics

Parent issue ticket - #730

Use Case

Quality

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@maxtybar maxtybar added the needs-triage This issue or PR still needs to be triaged. label Oct 3, 2024
@maxtybar maxtybar changed the title (bedrock): agent module refactor to follow best practices from CDK (bedrock): agent module refactoring to follow best practices from CDK Oct 3, 2024
@krokoko krokoko added the enhancement New feature or request label Oct 4, 2024
@krokoko
Copy link
Collaborator

krokoko commented Oct 15, 2024

@maxtybar just linking this ticket here as it can be included in the refactoring: #747

@maxtybar
Copy link
Contributor Author

@krokoko Sounds good, I am going to investigate it this week.

@krokoko krokoko added backlog and removed needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2024
@maxtybar maxtybar linked a pull request Oct 28, 2024 that will close this issue
Draft
@aws-rafams aws-rafams mentioned this issue Oct 29, 2024
Open
2 tasks
Closed
@krokoko krokoko mentioned this issue Nov 13, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bedrock): adopt to cdk best practices maxtybar/generative-ai-cdk-constructs
2 participants
@krokoko @maxtybar