feat(bedrock): adopt to cdk best practices #770
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `readonly` from actionGroups and knowledgeBases to prevent jsii errors Signed-off-by: Maksim Tybar <[email protected]>
Modifed `addActionGroup` function Signed-off-by: Maksim Tybar <[email protected]>
aws-rafams
reviewed
Oct 28, 2024
aws-rafams
reviewed
Oct 28, 2024
aws-rafams
reviewed
Oct 28, 2024
| /** | ||
| * Instance of Agent | ||
| */ | ||
| readonly agentInstance: bedrock.CfnAgent; |
There was a problem hiding this comment.
I wouldn't include this in the interface, as this implies that to import an existing agent you would need to pass a CfnAgent. I think it would be better to define it only on the Agent Class as a private readonly (internal) attribute (example on CDK lib).
There was a problem hiding this comment.
@aws-rafams If you have available cycles please take a look at this. There is also issues with IKnowledgeBase on the build. Thanks!
|
We can also update the KB associateToAgent method to take an IAgent, allowing to associate an imported agent |
krokoko
reviewed
Nov 7, 2024
| } else { | ||
| this.role = new iam.Role(this, 'Role', { | ||
| assumedBy: new iam.ServicePrincipal('bedrock.amazonaws.com'), | ||
| roleName: generatePhysicalNameV2( |
There was a problem hiding this comment.
we need to use the new capability of generatePhysicalNameV2 here to avoid collisions with name generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731 and #747
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.