Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'ACL' statement on default in ObjectUploader, not supported anymore by AWS S3. #3008

Closed
1 task
JortJacobs opened this issue Oct 4, 2024 · 3 comments
Closed
1 task
Assignees
Labels
closed-for-staleness guidance Question that needs advice or information. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@JortJacobs
Copy link

Describe the bug

Creating a folder via OctoberCMS results in ACL complaints since it is not being supported anymore.
This is related to the following file + line-item, containing 'ACL' statements:

'ACL' => $this->acl,
.

Please remove that.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

ObjectUploader to work.

Current Behavior

It does not work.

Reproduction Steps

Call the function.

Possible Solution

No response

Additional Information/Context

No response

SDK version used

Latest.

Environment details (Version of PHP (php -v)? OS name and version, etc.)

8.3.6

@JortJacobs JortJacobs added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2024
@JortJacobs JortJacobs changed the title (short issue description) 'ACL' statement on default in ObjectUploader, not supported anymore by AWS S3. Oct 4, 2024
@yenfryherrerafeliz yenfryherrerafeliz self-assigned this Oct 4, 2024
@RanVaknin
Copy link
Contributor

Hi @JortJacobs ,

ACLs being disabled by default is the expected and documented behavior and is controlled via the S3 service, not the SDK.

Please refer to:
Blogpost
S3 Notice
S3 docs

Thanks,
Ran~

@RanVaknin RanVaknin added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p2 This is a standard priority issue guidance Question that needs advice or information. and removed needs-triage This issue or PR still needs to be triaged. bug This issue is a bug. labels Oct 4, 2024
@stobrien89
Copy link
Member

stobrien89 commented Oct 4, 2024

Just wanted to chime in: the above only applies to buckets created on or after April 2023. Newly created buckets can be configured to enable ACLs, but ACLs no longer fall into S3's recommended security best practices. The SDK still sets a default ACL of private in the ObjectUploader class, which is legacy behavior that still works. We left this in place for backward compatibility reasons. S3 still allows private ACLs.

It sounds like OctoberCMS has a high-level filesystem abstraction over the SDK/S3 that relies on ACLs. If they are defaulting to anything other than private, they'll need to change that.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 5, 2024
@stobrien89 stobrien89 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 5, 2024
Copy link

This issue has not recieved a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness guidance Question that needs advice or information. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

4 participants