Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eb deploy doesn't zip symlinks-to-directories #511

Open
khaidirsh opened this issue Feb 15, 2024 · 0 comments
Open

eb deploy doesn't zip symlinks-to-directories #511

khaidirsh opened this issue Feb 15, 2024 · 0 comments

Comments

@khaidirsh
Copy link

Description

Symlink to directory not found in zipped application.

Seems commit 790cde6 produces this issue, because as Python documentation about os.walk:

... dirnames is a list of the names of the subdirectories in dirpath (including symlinks to directories, and excluding '.' and '..').

Thus, the mentioned commit has removed the process of including symlinks-to-directories into the zip.

Steps to reproduce

  1. Create directory as such:
folder_a/
├─ folder_b/
│  ├─ file_b
file_a
symlink_to_folder_b
  1. Run eb deploy

Observed result

symlink_to_folder_b fully skipped (not found in debug log)

...
2024-02-13 22:46:20,065 (INFO) eb :  +adding: ./folder_a/
2024-02-13 22:46:20,066 (INFO) eb :   +adding: ./folder_a/file_a
2024-02-13 22:46:20,068 (INFO) eb :  +adding: ./folder_a/folder_b/
2024-02-13 22:46:20,068 (INFO) eb :   +adding: ./folder_a/folder_b/file_b
...

Expected result

Symlink to directory added to application zip.

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

  1. OS: macOS 13.6.4
  2. EBCLI version: 3.20.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant