fix(sqs): does not print all failed validations for Queue props #33070
Conversation
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33070 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 226 226
Lines 13777 13777
Branches 2414 2414
=======================================
Hits 11235 11235
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
iankhou
changed the title
iankhou
force-pushed
the
iankhou-sqs-validation-refactor
branch
from
1d716cb to
9cc1efe
Compare
iankhou
force-pushed
the
iankhou-sqs-validation-refactor
branch
from
9cc1efe to
b38055d
Compare
iankhou
added
feature-request
iankhou
force-pushed
the
iankhou-sqs-validation-refactor
branch
from
fe0d832 to
bfc2ec5
Compare
| }, | ||
| { | ||
| condition: ({ redrivePermission, sourceQueues }) => | ||
| !!((redrivePermission === RedrivePermission.ALLOW_ALL || redrivePermission === RedrivePermission.DENY_ALL) && sourceQueues), |
There was a problem hiding this comment.
The logic for this used to essentially be:
redrivePermission && redrivePermission !== RedrivePermission.BY_QUEUE. If any more options were added to the RedrivePermission enum, the logic would have failed, since the permission might not be any of: byQueue, allowAll or denyAll. This adjusted logic protects against this possibility by being more specific.
There was a problem hiding this comment.
I like this! It's more defensive towards the unknown. ❤️
github-actions
bot
added
bug
iankhou
force-pushed
the
iankhou-sqs-validation-refactor
branch
from
8947922 to
a33f8b3
Compare
iankhou
changed the title
iankhou
changed the title
github-actions
bot
added
the
effort/small
iankhou
changed the title
iankhou
changed the title
iankhou
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #33098
Closes #33098.
Reason for this change
When initializing a new SQS Queue, props validation throws an error at the first validation issue encountered. If there are multiple validation issues, the user is only informed of the first one.
Description of changes
Using
validateAllPropspresents all validation errors to the user at once. IfredriveAllowPolicyis enabled, the policy will also be evaluated in the same way.Describe any new or updated permissions being added
No permissions changes.
Description of how you validated changes
Adjusted and added unit tests. Ran integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license