Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document VPC CNI helper metrics #2421

Closed
rittneje opened this issue Jun 14, 2023 · 11 comments
Closed

Document VPC CNI helper metrics #2421

rittneje opened this issue Jun 14, 2023 · 11 comments

Comments

@rittneje
Copy link

The documentation for the VPC CNI helper lists the names of the metrics that it will report, but does not explain what they mean, or how to use them to monitor the health of the cluster. Please add more detail on these points. https://github.com/aws/amazon-vpc-cni-k8s/blob/master/cmd/cni-metrics-helper/README.md

@jdn5126
Copy link
Contributor

jdn5126 commented Jun 15, 2023

Thanks for filing @rittneje , we are happy to take PRs if you have the bandwidth

@rittneje
Copy link
Author

@jdn5126 Is there any existing reference that explains them?

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Aug 19, 2023
@rittneje
Copy link
Author

not stale

@github-actions github-actions bot removed the stale Issue or PR is stale label Aug 20, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Oct 20, 2023
@rittneje
Copy link
Author

not stale

@github-actions github-actions bot removed the stale Issue or PR is stale label Oct 21, 2023
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Dec 21, 2023
@rittneje
Copy link
Author

not stale

@github-actions github-actions bot removed the stale Issue or PR is stale label Dec 22, 2023
@sidewinder12s
Copy link

@jdn5126 Is there any existing reference that explains them?

Just the code implementing them: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/utils/prometheusmetrics/prometheusmetrics.go#L31

@jdn5126
Copy link
Contributor

jdn5126 commented Feb 13, 2024

Closing following the merge of #2786

@jdn5126 jdn5126 closed this as completed Feb 13, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants