-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node version bump #235
Comments
Good idea and ... great opportunity for a contribution? Only one line to change:
Looking forward to the PR :) |
Had a look myself and it turned out to be more involving because with Node18 the aws-sdk is no longer available in the Lambda runtime enviroment, so you need to include it yourself (or switch to the V3 SDK which is even more involving). |
Updated to Node 16 for now |
Thank you for the very helpful sample. https://docs.aws.amazon.com/ja_jp/lambda/latest/dg/lambda-runtimes.html |
Plans yes, but we didn't get to it yet. If you want to send a PR don't hold back :) |
FYI, for anyone looking to deploy these as Lambda's with Node20.x My try to make this work found src/lambda-edge/shared/shared.tsrequired 2 changes: Then by packaging the provided existing function typescript code with esbuilder with the following tsconfig.json settings:
We also now have this packaged for deployment within terraform automation pipelines using this terraform provider: https://registry.terraform.io/providers/jSherz/node-lambda-packager/latest
We are only using the following: check-headers, http-headers, parse-auth, refresh-auth, sign-out functions. After some further testing the above is close, but still has some fundamental backend issues with the transfer to sdk3. |
Upgraded to Node v20! https://github.com/aws-samples/cloudfront-authorization-at-edge/releases/tag/v2.2.1 |
Hey, first thanks for the project, you provided. It's really cool !
I just wanted to mention, that maybe it might be a good idea to bump the node version of the tsconfig file. Currently, node 20 is already released whereas the project uses the config for node14, which might be suboptimal.
The text was updated successfully, but these errors were encountered: