Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.succeed would be called multiple times #7

Open
thesmart opened this issue Apr 15, 2016 · 1 comment
Open

context.succeed would be called multiple times #7

thesmart opened this issue Apr 15, 2016 · 1 comment

Comments

@thesmart
Copy link

thesmart commented Apr 15, 2016

I'm a little confused how the kinesis_lambda_es.js example is supposed to work. Documentation says that context.succeed, when called, will terminate the lambda.

However, the example would call context.succeed for every HTTP response callback of AWS ElasticSearch. Which is correct? These two sources seem to contradict each other. If the docs.aws.amazon.com site is correct, then wouldn't the context.succeed callback need to occur after ALL ES calls had their callbacks called?

@srisub-amzn
Copy link
Contributor

That's a good catch. I'll correct the code to call context.succeed() once all records are posted to Amazon Elasticsearch Service.

rishabh-amzn added a commit to rishabh-amzn/amazon-elasticsearch-lambda-samples that referenced this issue Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants