Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Usage of @ For Error Suppression #394

Open
sprankhub opened this issue Jul 21, 2017 · 0 comments
Open

Replace Usage of @ For Error Suppression #394

sprankhub opened this issue Jul 21, 2017 · 0 comments

Comments

@sprankhub
Copy link
Collaborator

In AvS_FastSimpleImport_Model_Import_Entity_Product::_getUploader and AvS_FastSimpleImport_Model_Import_Entity_Product::_getDownloadableUploader respectively, the @ is used to suppress errors. This should be avoided. A proper exception should be thrown if there is an issue. Additionally, if the directory is not writable, we should probably do a chmod instead of a mkdir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant