Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPanda: disable -monitor #101

Open
grant-h opened this issue Feb 16, 2022 · 3 comments
Open

PyPanda: disable -monitor #101

grant-h opened this issue Feb 16, 2022 · 3 comments

Comments

@grant-h
Copy link
Contributor

grant-h commented Feb 16, 2022

PyPanda's Panda() top-level class by default creates an interactive monitor like -monitor unix:/tmp/pypanda_mbwril7yr,server,nowait. I dont believe monitor is not the same as QMP, but a text based protocol

There are couple of ideas:

The main reason for disabling this is that running PyPanda many times can end up polluting /tmp

@grant-h grant-h changed the title PyPanda: avoid duplicate monitor PyPanda: disable -monitor Feb 16, 2022
@rawsample
Copy link
Member

rawsample commented Feb 17, 2022

Hi!

Disabling PyPanda's monitor should be currently possible via additional_args in the QemuTarget because of assemble_cmd_line() here.

But i would be in favor on changing the default behavior via a new option in PyPanda target.

@grant-h
Copy link
Contributor Author

grant-h commented Feb 17, 2022

I tried that, but doesn't raw_monitor needs to be passed as a kwarg, not an array of strings. Can you show me?

@rawsample
Copy link
Member

rawsample commented Feb 18, 2022

My bad, it's kwargs from init_target that should be used. Unfortunately this would not work using Avatar's init_targets() :/

from avatar2 import Avatar
from avatar2.targets import PyPandaTarget

av = Avatar()
pp = PyPandaTarget(av)

pp.init(raw_monitor=True)

pp.shutdown()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants