Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper Handling of Required Parameters #64

Open
marvillage opened this issue Oct 23, 2024 · 1 comment
Open

Improper Handling of Required Parameters #64

marvillage opened this issue Oct 23, 2024 · 1 comment
Assignees

Comments

@marvillage
Copy link

The constructor for the EnableStudents class checks for required parameters and logs errors, but it does not raise an exception that can be handled upstream in a consistent manner.

Steps to Reproduce:

Create an instance of EnableStudents without providing the required parameters.
Observe the application behavior.
Expected Behavior:
The application should raise a ValueError and terminate the process when required parameters are missing.

Actual Behavior:
The application logs errors but does not handle them properly, which may lead to undefined behavior later.

@suryabulusu
Copy link
Contributor

Hmm. Can you think of a way we can log better? You may also check portal-frontend's user.js which actually makes requests to this part of the code for registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants