Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOTP code cannot be copied from VaultListItem component #493

Open
capaj opened this issue Jul 9, 2024 · 3 comments
Open

TOTP code cannot be copied from VaultListItem component #493

capaj opened this issue Jul 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@capaj
Copy link
Collaborator

capaj commented Jul 9, 2024 •
edited
Loading

in popup we show and allow user to copy paste a TOTP code.
In vault we have a button to copy which works well for credentials, but for TOTP it does not do anything

there is a TODO in the code here:

authier/web-extension/src/components/vault/VirtualizedList.tsx

Line 151 in d7848aa

// TODO implement this see issue #493

@capaj
Copy link
Collaborator Author

capaj commented Jul 9, 2024

@MentatBot can you try to solve this?

@capaj capaj added the bug Something isn't working label Jul 9, 2024
@capaj
Copy link
Collaborator Author

capaj commented Jul 10, 2024

@MentatBot second try

@mentatbot MentatBot
Copy link

mentatbot bot commented Jul 10, 2024

I will start working on this issue

mentatbot bot pushed a commit that referenced this issue Jul 10, 2024
Fix TOTP Code Copy Functionality in Device List
407c5a9 
This commit addresses issue #493 by adding the ability to copy TOTP codes from the device list in the vault. The following changes were made:
- Introduced a new state variable `TOTPCode` in `DeviceListItem` to store the TOTP code.
- Added a `handleCopyTOTP` function to copy the TOTP code to the clipboard.
- Included a "Copy TOTP" button in the device list item UI, which appears if a TOTP code is available.
- Passed the `TOTPCode` prop to `DeviceListItem` from the parent `Devices` component.
@mentatbot mentatbot bot mentioned this issue Jul 10, 2024
Closed
@capaj capaj changed the title TOTP code cannot be copied from device list in vault TOTP code cannot be copied from VaultListItem component Jul 10, 2024
mentatbot bot pushed a commit that referenced this issue Jul 10, 2024
Fix TOTP Code Copy Functionality in VaultListItem Component
67b31a0 
This commit addresses issue #493 by adding the ability to copy TOTP codes from the VaultListItem component. The following changes were made:
- Introduced a new state variable `TOTPCode` in `VaultListItem` to store the TOTP code.
- Added a `handleCopyTOTP` function to copy the TOTP code to the clipboard and show a success toast.
- Included a "Copy TOTP" button in the VaultListItem UI, which appears if a TOTP code is available.

Closes #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TOTP Code Copy Functionality in Device List authier-pm/authier
1 participant
@capaj