Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scheme callback modification under the hood. #915

Closed
6 tasks done
david-shiko opened this issue Jun 5, 2024 · 2 comments
Closed
6 tasks done

Wrong scheme callback modification under the hood. #915

david-shiko opened this issue Jun 5, 2024 · 2 comments
Labels
bug This points to a verified bug in the code

Comments

@david-shiko
Copy link

Checklist

Description

Please check this line

scheme = scheme + '.auth0';

I think it's broking the suggested url from the docs and personal space.

Reproduction

Additional context

No response

react-native-auth0 version

"react-native-auth0": "^3.1.0",

React Native version

"react-native": "0.74.1",

Expo version

No response

Platform

Android

Platform version(s)

Linux david-comp 6.5.0-35-generic #35~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue May 7 09:00:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

@david-shiko david-shiko added the bug This points to a verified bug in the code label Jun 5, 2024
@poovamraj
Copy link
Contributor

Hey @david-shiko, sorry on the delayed response. Any chance you checked out the migration guide mentioned here - https://github.com/auth0/react-native-auth0/blob/master/MIGRATION_GUIDE.md#upgrading-from-v2---v3

The change you mentioned is an artifact of this version change.

@poovamraj
Copy link
Contributor

@david-shiko We will close this issue for now as it looks like we just needed to handle the migration required. Happy to reopen this issue if required, you can comment here for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants