Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of code by using y and df accordingly #105

Open
hagenw opened this issue Mar 13, 2023 · 0 comments
Open

Improve readability of code by using y and df accordingly #105

hagenw opened this issue Mar 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@hagenw
Copy link
Member

hagenw commented Mar 13, 2023

As mentioned in #104 (comment) we use y at some places to represent not only a series, but other objects as well.
As this is not expected behavior compared to other code we write we should change this and use some more generic names like results whenever y or df to not represent a series or dataframe.
@hagenw hagenw added the enhancement New feature or request label Mar 13, 2023
@hagenw hagenw mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hagenw