unix: move clipboard utility discovery out of init() #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstromberg
changed the title
tstromberg
changed the title
tstromberg
changed the title
norbjd
reviewed
May 22, 2022
| } | ||
|
|
||
| func readAll() (string, error) { | ||
| if Unsupported { | ||
| c := findClipboardUtility() |
There was a problem hiding this comment.
Hi 👋 just a small comment: instead of instantiating a new commandInfo every time readAll() or writeAll() is called, should it be possible to create a singleton:
var instance commandInfo
var once sync.Once
func GetInstance() commandInfo {
once.Do(func() {
instance = findClipboardUtility()
})
return instance
}And call c := GetInstance() instead of c := findClipboardUtility()?
It will be quicker since findClipboardUtility() will be called only once (at the first call).
What do you think? BTW, thanks for this PR 🙌
There was a problem hiding this comment.
I considered this option, but it didn't seem worth the additional complication for a call that is unlikely to be called very often. If making this change helps the PR get merged though, I'm all for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
This moves the clipboard utility code from
init()to a function namedfindClipboardUtility(). While this has a minor performance impact if theWriteAllorReadAllcommand is called in a loop, this does improve binary start time.It also looks a whole lot less scary in system call traces. This is particularly important for programs that indirectly import but never use this library.
As part of the cleanup, I removed references to an unused
Primaryglobal. Please let me know if you would like me to put them back.