Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external format doesn't support pids #1350

Closed
pguyot opened this issue Oct 22, 2024 · 4 comments · Fixed by #1358
Closed

external format doesn't support pids #1350

pguyot opened this issue Oct 22, 2024 · 4 comments · Fixed by #1358

Comments

@pguyot
Copy link
Collaborator

pguyot commented Oct 22, 2024

Instead of a badarg exception, when calling term_to_binary(self())., VM prints:

Unknown external term type: 19

and then aborts.
@pguyot pguyot mentioned this issue Oct 22, 2024
Open
@pguyot
Copy link
Collaborator Author

pguyot commented Nov 3, 2024

Fixed in #1358

@pguyot pguyot mentioned this issue Nov 3, 2024
Merged
bettio added a commit that referenced this issue Dec 21, 2024
@bettio
Merge pull request #1358 from pguyot/w44/encode_and_decode_local_pids
fae8f60 
Add support for encoded local pids in external terms

Fixes #1350

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Jan 20, 2025 •
edited
Loading

Closing this because the fix #1358 was merged. It was not closed automatically because the PR comment said "Fixes" rather than "Closes" #1350 ;-)

@pguyot
Copy link
Collaborator Author

pguyot commented Jan 21, 2025

Closing this because the fix #1358 was merged. It was not closed automatically because the PR comment said "Fixes" rather than "Closes" #1350 ;-)

I believe it wasn't closed because commit from PR 1358 was merged on a branch and not on main.

@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Jan 21, 2025 •
edited
Loading

Oh shoot! You are right, this isn't in main yet. I thought the auto-close feature was just picky about using "closes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for encoded local pids in external terms pguyot/AtomVM
2 participants
@pguyot @UncleGrumpy