-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird skipping during playback #116
Comments
I think this has something to do with it: _onProgressBarDidProgress: (percentProgress) =>
progress = @progressFromPercent percentProgress
# if slider progress differs from player progress, seek to new position
unless progress.toFixed(5) == @seekOffset().toFixed(5)
@seek progress |
@jbenet the example you posted is a private, inaccessible youtube video. What do you expect is happening because of that code? |
@tenedor fixed video private -> unlisted |
That sometimes youtube seek offset advances at before it gets compared, so that when the comparison in the video skips back, so |
This a) shouldn't happen and if it did b) shouldn't cause the problem you're seeing. a) This shouldn't happen because, when a user hasn't sought to a new location, the progress bar only updates to keep pace with the youtube video. This update and the event it throws, which triggers the method you posted, is a minimal amount of code to run, and would happen long before the youtube video progressed to a new time. This assumes the youtube player progresses at regular intervals - if it progressed multiple intervals at once, this might cause a bug. b) This shouldn't cause the problem you're seeing, because the undesired seek would seek to the last offset that was registered correctly, likely only one frame earlier than the one playing. In the video you show, the seek is to some different part of the video, not simply to 0.1 second earlier in the video. |
the only way to know for sure is to comment it out and see if it stops. On Sunday, May 5, 2013 at 5:00 PM, Daniel Windham wrote:
|
Sometimes during playback, the video skips.
Only observed so far in spliced videos. Unclear whether it happens in regular videos too.
see example
The text was updated successfully, but these errors were encountered: