Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fragment navigation issue fix #1098

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

aditygrg2
Copy link
Contributor

Description

Changes proposed in this pull request:
Fixed the issue by using window.location.pathname in the href attribute, so that full URL (current path + fragment) is generated when clicking on server links.

Related issue(s)
Fixes #1097

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@aditygrg2 aditygrg2 changed the title Fix Fragment Navigation Issue fix: Fragment Navigation Issue Oct 18, 2024
@aditygrg2 aditygrg2 changed the title fix: Fragment Navigation Issue fix: fragment navigation issue fix Oct 18, 2024
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Oct 23, 2024

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit fdd826e into asyncapi:master Oct 23, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants