Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF.js plugin problems in FireFox / Safari #8

Open
lpmagnuson opened this issue Jan 7, 2020 · 1 comment
Open

PDF.js plugin problems in FireFox / Safari #8

lpmagnuson opened this issue Jan 7, 2020 · 1 comment

Comments

@lpmagnuson
Copy link

Hi, I attempted to install this plugin in our OJS instance but activating the plugin and attempting to make the required PDF changes results in the PDFs not actually loading in the browser in FireFox and Safari (the PDF viewer loads, along with the hypothesis tools, but the actual PDF content itself never loads). The integration seems to work perfectly with Chrome. I saw this comment/issue that seems to indicate that perhaps the PDF.js plugin that's included in OJS is no longer compatible; is there any solution to potentially get this working? I did have to hack the included PDF.js plugin a bit since the referenced .diff patch wouldn't work with our existing PDF.js install (which is the same one that comes packaged with OJS 3.x).

Thanks for developing this and for any help!

Lauren

@asmecher
Copy link
Owner

asmecher commented Jan 7, 2020

@lpmagnuson, until the work is done in the issue you linked above, it's unfortunately necessary to choose between either a current PDF.js PDF reader, or Hypothes.is integration with an old one. The Hypothes.is team manages the integration between PDF.js and Hypothes.is; the PKP team (that includes me) just manage the integration between either product and OJS. It might be helpful if you threw in a +1 on the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants