Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monte Carlo error estimation issue #54

Open
ritviksainarayan opened this issue Dec 6, 2024 · 0 comments
Open

Monte Carlo error estimation issue #54

ritviksainarayan opened this issue Dec 6, 2024 · 0 comments

Comments

@ritviksainarayan
Copy link


Relevant Materials

tauceti_LS.txt
tauceti_PS.txt

Description

The code runs without any issues while I don't use the Monte Carlo estimation for errors. I get hit with the following error when I do so,

(100_days_code) > pysyd run --star tauceti -dv --mc 200

-----------------------------------------------------------
Target: tauceti
-----------------------------------------------------------

-----------------------------------------------------------
PS binned to 179 datapoints

Numax estimates
---------------
Estimate 1: 4095.84 +/- 789.42
S/N: 5.77
Estimate 2: 2300.65 +/- 144.49
S/N: 1.00
Estimate 3: 5111.85 +/- 67784.75
S/N: 0.00
Selecting model 1
-----------------------------------------------------------
GLOBAL FIT
-----------------------------------------------------------
PS binned to 119 data points

Background model
----------------
Comparing 8 different models:
Model 0: 0 Harvey-like component(s) + white noise fixed
 BIC = 0.00 | AIC = 0.00
Model 1: 0 Harvey-like component(s) + white noise term
 BIC = 4.78 | AIC = 0.02
Model 2: 1 Harvey-like component(s) + white noise fixed
 BIC = 9.56 | AIC = 0.03
Model 3: 1 Harvey-like component(s) + white noise term
 BIC = 14.34 | AIC = 0.05
Model 4: 2 Harvey-like component(s) + white noise fixed
 BIC = 19.12 | AIC = 0.07
Model 5: 2 Harvey-like component(s) + white noise term
 BIC = 23.90 | AIC = 0.08
Model 6: 3 Harvey-like component(s) + white noise fixed
 BIC = 28.67 | AIC = 0.10
Model 7: 3 Harvey-like component(s) + white noise term
 BIC = 33.45 | AIC = 0.12
Based on BIC statistic: model 0
-----------------------------------------------------------
Sampling routine (using seed=6427319):
  0%|                                                                                                                                                                                                               | 0/200 [00:00<?, ?it/s]Traceback (most recent call last):
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/bin/pysyd", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/cli.py", line 663, in main
    args.func(args)
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/pipeline.py", line 193, in run
    _pipe(args.stars, params)
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/pipeline.py", line 133, in _pipe
    star.process_star()
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/target.py", line 157, in process_star
    self.derive_parameters()
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/target.py", line 994, in derive_parameters
    self.get_samples()
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/target.py", line 1253, in get_samples
    if self.single_step():
       ^^^^^^^^^^^^^^^^^^
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/target.py", line 1210, in single_step
    self.get_background()
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/pysyd/target.py", line 1530, in get_background
    self.params['pars'], _ = curve_fit(self.params['functions'][self.params['selected']](self.params['noise']), self.bin_freq, self.bin_pow, p0=self.params['guesses'][:-1], sigma=self.bin_err, bounds=self.params['bounds'])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ritviksainarayanan/anaconda3/envs/100_days_code/lib/python3.12/site-packages/scipy/optimize/_minpack_py.py", line 965, in curve_fit
    ysize = len(infodict['fvec'])
            ^^^^^^^^^^^^^^^^^^^^^
TypeError: object of type 'numpy.float64' has no len()
  0%|▉                                                   

Computing

Please provide (by editing) the following information:

  • OS: [macOS]
  • Version: [15.1.1]
  • Implementation: [command line]

Attachments

In order to reproduce the issue from our end, please provide both the light curve and power spectrum for the relevant target!

Attach the required data files here and if applicable, any figures or screenshots to help explain your problem.

Other

Add any other relevant information here (e.g., links to related issues or solutions)


Summary Checklist:

  • How were you using pySYD when you experienced the issue?
    • CLI
    • API
    • jupyter
  • Did you provide all the relevant information and files so that we can reproduce the error?
    • Yes
    • No
  • Did you check if the issue has already been reported?
    • Yes
      → Was there a proposed workaround or solution?
      • Yes
      • No
      • Idk
    • No
  • Do you know if the issue is version specific?
    • Yes*
    • No
    • Idk
  • Have you identified a workaround or solution?
    • Yes*
    • No
  • Will you be submitting a pull request associated with this issue?
    • Yes
    • No
    • Idk

* If you selected 'Yes' for any of these points, please expand on each of them in more detail below.
Note: If you found any relevant threads, questions, solutions or are submitting a pull request, please remember to provide links for any/all as these are incredibly helpful for future users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant