Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sections #52

Open
zachdaniel opened this issue Aug 14, 2023 · 2 comments
Open

Remove Sections #52

zachdaniel opened this issue Aug 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@zachdaniel
Copy link
Contributor

Currently, sections don't really give us much, and ought to be replaceable with Entities.

We can shift our DSL builder to just use entities, and then we just import the top level entity. The only thing we need to support is a config on entities that repeated calls to it merge configs (like sections to).

@zachdaniel zachdaniel added the enhancement New feature or request label Aug 14, 2023
@joshprice
Copy link
Contributor

This would alleviate some confusion, it's hard to explain what the difference really is.

@zachdaniel
Copy link
Contributor Author

Agreed. Unfortunately this would be a massive change that may never make the cut in terms of wether or not its worth it. But yeah it should have just been entities (i.e struct constructors) all the way down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants