Adding initial files with limited functionality support for OXC in Elixir #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! I'll merge this as it is and set it up to be one of our projects. The effort to set it up for recompilation etc. is not something I will be able to put in personally until I have something that I need to use igniter_js for, which I'm sure will happen some day soon :) Our original case was for adding an export to tailwind.config.js but that is going away in tailwind 4 😆 I will be doing some js codegen work in the near future though and will look into precompilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this pull request is to add functionalities related to JavaScript manipulation, aiming to enable its use with Igniter in Mix tasks (based on ash-project/igniter#106).
Description
As discussed in the Ash Discord, this requires some configuration and optimizations. Please apply the necessary changes based on the requirements.
For instance, precompiling beforehand to avoid taking up significant time from the user each time is a good example. Additionally, this should be handled based on the user's operating system.
Here’s an example:
https://github.com/tessi/wasmex/blob/main/.github/workflows/release.yml
And also in the Elixir section:
https://github.com/tessi/wasmex/blob/main/lib/wasmex/native.ex#L8-L24
The module related to the JavaScript parser:
lib/igniter_js/parsers/javascript/parser.exAnd the test module:
test/parsers/javascript/parser_test.exsMy short-term goal is to maintain these functions as they are. Over time, I plan to add other OXC functions based on improved personal experience to make working with JavaScript easier.
Best regards,
Shahryar Tavakkoli